-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StackedNotificationsBehavior port #170
Conversation
…w notification in sample
…Toolkit control Adds additional `Show` methods to act as backward compatibile helpers.
…ve constant values for Notifications Added test for override scenario
…r Closing event Added a Clear method to clear all notifications on the StackedNotificationsBehavior Added more migration notes
600769f
to
46b8b43
Compare
Force pushed, forgot to adjust author of initial port commit, did an interactive rebase and:
|
@michael-hawker updated the icon, made a minor tweak to the samples so they don't "jump" whenever a notification is shown using a |
Seeing the tests failing with our unknown platform issue again, updating our build script with the diagnostic log flags to get more info (also updating some versions and other things needed by the CI that had diverted from Labs, like the Page file and non-.NET Native release). |
…ckedNotificationsBehavior
With the extra diagnostics I did see there was an issue in the StackedNotificationsBehavior test due to the timer firing after the test had removed the UI element, so I fixed that by adding the |
Added some extra build diagnostics to analyze crashes a bit in the pipeline itself (if they occur). Also trying to ignore the called out test and see what happens. 🤞 @Arlodotexe any concerns with the build modifications, think we can leave the diagnostics on all the time for now to help us, as the large dump only gets uploaded if there was a dump, so any good builds won't add much extra noise or size anyway? |
This migrates, updates, and amends the
StackedNotificationsBehavior
from Labs by @vgromfeldThis PR provides:
Behaviors
componentClear
method to remove all NotificationsIconSource
toNotification
to allow for custom icons per notificationSeverity
andTitle
, thus allowing parent properties on anInfoBar
to be set and used by all notifications more easilyMigration Notes from InAppNotification:
StackMode
to change behavior of queuing messages, was thinking of adding, but then realized it was a more disruptive user experience in general to replace an active notification. Added a note, thoughts @niels9001?Opened
/Opening
event for the notification. Theoretically you should be able to just register to theIsOpen
property changed notification... see related platform issue withInfoBar
itself: Proposal: Add 'Opened' event to InfoBar microsoft/microsoft-ui-xaml#3761Needs: