-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting Primitives #18
Conversation
@niels9001 some Uno related errors:
One should be an easy fix, not sure about the overrides. May want to compare against the Uno fork? |
@niels9001 what's the exception for staggered? Is it the Panel or the Layout? Is it UWP and/or WASDK? |
WinUI 2 job failed due to .NET Native. WinUI 3 job is failing due to test?
|
@michael-hawker Got that for you. Here's the relevant parts of the
|
Thanks @Arlodotexe, that's weird. It looks like an exception in the sample markdown parser itself vs. the panel... |
Discovered Uno has their own WrapPanel implementation, so causes namespace conflicts with ours and how we do global usings. Have a fix in the sample for it now. Removed some of the markdown from the Staggard page and it seems to be working for me on UWP? We'll have to add an issue to the tasklist about fixing the bindings for the sample. @Arlodotexe I tried to understand how the generated option binding works and where the property is. Is there not a property value on the page somewhere, did I miss it? Could we do something like |
fa91a76
to
929c71c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed up fixes, think we'll be in a good enough state for now assuming CI passes.
Did notice the issues with UniformGrid on WASM as well. Otherwise, just WrapPanel binding it seems is the other issue.
Tested on UWP, WinAppSDK, and WASM. Looks good.
929c71c
to
26ac162
Compare
Oops, missed an update in one case of the switch to |
For #8
Known issues:
WrapPanel sample
ItemsPanelTemplate
doesn't work.UniformGrid sample
ContrainedBox sample
StaggeredSamples.md