Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seems the splitting is not working #95

Closed
Longhan9926 opened this issue Jan 19, 2025 · 2 comments · Fixed by #97
Closed

Seems the splitting is not working #95

Longhan9926 opened this issue Jan 19, 2025 · 2 comments · Fixed by #97
Labels
bug Something isn't working

Comments

@Longhan9926
Copy link

Longhan9926 commented Jan 19, 2025 •
edited
Loading

It appears that by calling Subset.dataset in train_ensemble, the whole dataset is used instead of the split ones.

Image Image
@CompRhys
Copy link
Owner

55e41a8 seemingly this bug was introduced here. @janosh. The bug was introduced after the results presented in the papers but will look at fixing this. Thanks for reporting!

CompRhys added a commit that referenced this issue Jan 20, 2025
@CompRhys
fix: address subset issue highlighted in #95
f5bfcc5
@janosh
Copy link
Collaborator

janosh commented Jan 20, 2025

oops, sorry about that. glad @Longhan9926 eventually caught this! 👍

@janosh janosh added the bug Something isn't working label Jan 20, 2025
@CompRhys CompRhys linked a pull request Jan 20, 2025 that will close this issue
Address subset issue highlighted in #95 #97
Merged
CompRhys added a commit that referenced this issue Jan 21, 2025
@CompRhys
Address subset issue highlighted in #95 (#97)
181e2b2 
* fix: address subset issue highlighted in #95

* test: add checks that would have caught the test set subset issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Address subset issue highlighted in #95 CompRhys/aviary
3 participants
@CompRhys @janosh @Longhan9926