Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bootloader password for RHEL8 kickstart #10014

Merged

Conversation

jskacel
Copy link
Contributor

@jskacel jskacel commented Jan 2, 2023

Fixing bootloader password

Description:

Bootloader password must be in Grub PBKDF2 format and also parameter --iscrypted must be provided. See https://pykickstart.readthedocs.io/en/latest/commands.html#bootloader

Rationale:

  • Password was wrong in kickstart

Review Hints:

  • Install RHEL8 with kickstart and try to edit GRUB line

Fixing bootloader password
@openshift-ci
Copy link

openshift-ci bot commented Jan 2, 2023

Hi @jskacel. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 2, 2023
@github-actions
Copy link

github-actions bot commented Jan 2, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@marcusburghardt marcusburghardt added the bugfix Fixes to reported bugs. label Jan 3, 2023
@codeclimate
Copy link

codeclimate bot commented Jan 3, 2023

Code Climate has analyzed commit 55c10dc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.8% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Jan 3, 2023
@Mab879 Mab879 added this to the 0.1.66 milestone Jan 4, 2023
@Mab879 Mab879 added CIS CIS Benchmark related. RHEL9 Red Hat Enterprise Linux 9 product related. RHEL8 Red Hat Enterprise Linux 8 product related. and removed RHEL9 Red Hat Enterprise Linux 9 product related. labels Jan 4, 2023
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Mab879 Mab879 merged commit 8cb39ae into ComplianceAsCode:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs. CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. RHEL8 Red Hat Enterprise Linux 8 product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants