Remove check of /var/log/dmesg from OVAL #10145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike the output of the dmesg command, the corresponding file may be binary, and therefore unsuitable to be examined by the textfilecontent OVAL test, as that one assumes that the file is encoded in UTF-8. Moreover, the removed checking regex was quite fragile, which was probably caused by the NX feature having different name on different platforms and the corresponding log entry not being designed as machine-readable.
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
|
This datastream diff is auto generated by the check Click here to see the full diffOVAL for rule 'xccdf_org.ssgproject.content_rule_bios_enable_execution_restrictions' differs.
--- oval:ssg-bios_enable_execution_restrictions:def:1
+++ oval:ssg-bios_enable_execution_restrictions:def:1
@@ -1,4 +1,3 @@
criteria AND
criterion oval:ssg-test_NX_cpu_support:tst:1
-criterion oval:ssg-test_messages_nx_active:tst:1
criterion oval:ssg-test_noexec_cmd_line:tst:1 |
|
Code Climate has analyzed commit 8063e6a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 49.5% (0.0% change). View more on Code Climate. |
Mab879
added
STIG
|
At least in RHEL 8 STIG reads as follows So I'm okay with removing this. |
Mab879
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Don't check
/var/log/dmesgusing OVAL, because it may legitimately fail.However, the rule has a STIG ID, so I guess that modifying its check isn't so simple - whoever understands this, please clarify.
Rationale:
Unlike the output of the dmesg command, the corresponding file may be binary, and therefore unsuitable to be examined by the textfilecontent OVAL test, as that one assumes that the file is encoded in UTF-8.
Moreover, the removed checking regex was quite fragile, which was probably caused by the NX feature having different name on different platforms and the corresponding log entry not being designed as machine-readable.