Fixes related to SLE 12/15 for the rules set_min/max_life_existing

[rumch-se]

Description:

• _Fixes in bash/ansible and rule part of 2 SLE 12/15 rules _

Rationale:

• Fixes cover the following common issues in SLE 12/15 rules accounts_password_set_max_life_existing, and accounts_password_set_min_life_existing: 1)The rules as they exist do not update all rows (all accounts) in /etc/shadow 2)When PAM module is active on the OS - the session token expires during the execution of the rules 3)The rules.yml files do not present fact that the rule is applicable for all users 4)The realization of the rules had differences - for example in both cases we have variables, but for in the one the rules the variable was not used - in general in both cases the approach should be similar

[openshift-ci]

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[github-actions]

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff

bash remediation for rule 'xccdf_org.ssgproject.content_rule_accounts_password_set_max_life_existing' differs.
--- xccdf_org.ssgproject.content_rule_accounts_password_set_max_life_existing
+++ xccdf_org.ssgproject.content_rule_accounts_password_set_max_life_existing
@@ -1,5 +1,6 @@
 
 var_accounts_maximum_age_login_defs=''
+
 
 
 while IFS= read -r i; do

bash remediation for rule 'xccdf_org.ssgproject.content_rule_accounts_password_set_min_life_existing' differs.
--- xccdf_org.ssgproject.content_rule_accounts_password_set_min_life_existing
+++ xccdf_org.ssgproject.content_rule_accounts_password_set_min_life_existing
@@ -1,5 +1,6 @@
 
 var_accounts_minimum_age_login_defs=''
+
 
 
 while IFS= read -r i; do

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)

Fedora Testing Environment

Oracle Linux 8 Environment

[jan-cerny]

I think you can avoid nesting conditions and have an if-elif instead.

[jan-cerny]

I would prefer the opposite condition instead of using a negative condition.

[rumch-se]

Hello @jan-cerny
Thank you for your feedback.
The proposed corrections were done.
Have a nice day
Rumen

[codeclimate]

Code Climate has analyzed commit c2dfe8a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 51.7% (2.2% change).

View more on Code Climate.