Include rule for checking password last change in RHEL #10243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusburghardt
added
RHEL
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
jan-cerny
approved these changes
Feb 22, 2023
jan-cerny
requested changes
Feb 22, 2023
The accounts_password_last_change_is_in_past rule also satisfies the CIS requirements for RHEL7, RHEL8 and RHEL9.
The OVAL check returns "unknown" when there is no password defined in the /etc/shadow file. It is necessary to include a test scenario for this case since it is relatively common to happen.
marcusburghardt
force-pushed
the
cis_rhel_pass_past
branch
from
24400c9 to
13ac521
Compare
|
This datastream diff is auto generated by the check Click here to see the full diffNew content has different text for rule 'xccdf_org.ssgproject.content_rule_accounts_password_last_change_is_in_past'.
--- xccdf_org.ssgproject.content_rule_accounts_password_last_change_is_in_past
+++ xccdf_org.ssgproject.content_rule_accounts_password_last_change_is_in_past
@@ -8,6 +8,12 @@
[warning]:
Automatic remediation is not available, in order to avoid any system disruption.
+[reference]:
+5.6.1.5
+
[rationale]:
If a user recorded password change date is in the future then they could
bypass any set password expiration.
+
+[ident]:
+CCE-86525-3
OVAL for rule 'xccdf_org.ssgproject.content_rule_accounts_password_last_change_is_in_past' differs.
--- oval:ssg-accounts_password_last_change_is_in_past:def:1
+++ oval:ssg-accounts_password_last_change_is_in_past:def:1
@@ -1,2 +1,3 @@
-criteria None
-criterion oval:ssg-test_accounts_password_last_change_time_secs:tst:1
+criteria OR
+criterion oval:ssg-test_accounts_password_last_change_is_in_past:tst:1
+criterion oval:ssg-test_accounts_password_last_change_is_in_past_no_pass:tst:1 |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
The previous check was reporting "unknown" when there is no password defined in the /etc/shadow file of the checked system. Before, it was not clear the reason for the unknown result. Therefore, a new test was included to check if passwords are inexistent in the system. The rule is no longer reporting "unknown" and the generated reports are more clearly informing which checks passed or not.
marcusburghardt
force-pushed
the
cis_rhel_pass_past
branch
from
13ac521 to
8def7b5
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
Code Climate has analyzed commit 8def7b5 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 51.7% (0.0% change). View more on Code Climate. |
The 8def7b5 fixes this issue. More details in the commit description. |
jan-cerny
approved these changes
Feb 27, 2023
marcusburghardt
added
Update Rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
accounts_password_last_change_is_in_pastrule also satisfies the CIS requirements for RHEL7, RHEL8 and RHEL9.Rationale:
Better CIS coverage for RHEL.