Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /dev/shm to CIS Kickstarts #10286

Merged
merged 8 commits into from
Mar 16, 2023
Merged

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Mar 3, 2023

Description:

Adds /dev/shm to the RHEL 9 and RHEL 7 CIS Workstation Level 2 kickstart files.

Rationale:

Help fix kickstart installs.

Closes #10274

@Mab879 Mab879 added bugfix Fixes to reported bugs. RHEL9 Red Hat Enterprise Linux 9 product related. labels Mar 3, 2023
@Mab879 Mab879 added this to the 0.1.67 milestone Mar 3, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@mildas
Copy link
Contributor

mildas commented Mar 7, 2023

@Mab879 The /dev/shm issue is gone.
But unfortunately #10277 is not fixed because a different issue got revealed after the installation started. The issue is package conflict. So, please remove the Fix #10277 description so the issue is not closed after merge and then it's good to be merged.

@Mab879
Copy link
Member Author

Mab879 commented Mar 7, 2023

@mildas The description has been updated.

Copy link
Contributor

@mildas mildas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update root partition in RHEL7 kickstart similarly as in RHEL9 to not exceed 20GB.

@marcusburghardt
Copy link
Member

@mildas , could you confirm the new partition size is good for the testing purposes, please?

@mildas
Copy link
Contributor

mildas commented Mar 13, 2023

@marcusburghardt Sure, I will test both, RHEL7 and RHEL9, when root partition for RHEL7 is updated.

Edit: Actually, I can't verify it. The partition is not the only issue with installation. With this PR, I can finally begin the installation, but few seconds after start the installation aborts, see #10277 (comment)

Copy link
Contributor

@mildas mildas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mab879 Workstation L2 partitions look good now. But now I've checked CIS control files and the rule is applicable to all CIS profiles (both Workstation and Server and even for Level 1)
https://github.com/ComplianceAsCode/content/blob/master/controls/cis_rhel7.yml#L94
https://github.com/ComplianceAsCode/content/blob/master/controls/cis_rhel9.yml#L258

Please, update also Workstation L1, Server L1, and Server L2 kickstart same as you did for Workstation L2 (RHEL7 + RHEL9, 512MB for /dev/shm and reduce /).

@Mab879 Mab879 changed the title Add /dev/shm to CIS Workstation Level 2 Kickstart on RHEL 9 Add /dev/shm to CIS Kickstarts Mar 15, 2023
@codeclimate
Copy link

codeclimate bot commented Mar 15, 2023

Code Climate has analyzed commit 808d12c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 51.7%.

View more on Code Climate.

@mildas
Copy link
Contributor

mildas commented Mar 15, 2023

/packit retest-failed

@mildas
Copy link
Contributor

mildas commented Mar 16, 2023

/packit retest-failed

@mildas
Copy link
Contributor

mildas commented Mar 16, 2023

/packit build

@yuumasato
Copy link
Member

The updates in Kickstart are not relevant for tests running in Testing Farm.

@yuumasato yuumasato merged commit c08d35d into ComplianceAsCode:master Mar 16, 2023
@Mab879 Mab879 deleted the fix_10277 branch March 21, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs. RHEL9 Red Hat Enterprise Linux 9 product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RHEL7 and RHEL9 CIS Kickstarts don't configure partition for /dev/shm
4 participants