Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off avahi and avahi-autoipd fixes during install #10341

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Mar 17, 2023

Description:

Since gnome-desktop requires libsane-hpaio which requires avahi having avahi removed during the install of the OS causes the install to fail.

Rationale:

Fixes #10277

@Mab879 Mab879 added bugfix Fixes to reported bugs. RHEL9 Red Hat Enterprise Linux 9 product related. CIS CIS Benchmark related. labels Mar 17, 2023
@Mab879 Mab879 added this to the 0.1.67 milestone Mar 17, 2023
@Mab879 Mab879 self-assigned this Mar 17, 2023
@Mab879 Mab879 force-pushed the fix_10277_package branch from 5bc136b to 089d929 Compare March 17, 2023 21:43
@github-actions
Copy link

github-actions bot commented Mar 17, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 removed their assignment Mar 20, 2023
@Mab879 Mab879 changed the title Turn off avahi and avahi-autoipd fixes durning install Turn off avahi and avahi-autoipd fixes during install Mar 20, 2023
@jan-cerny jan-cerny assigned jan-cerny and unassigned jan-cerny Mar 20, 2023
@Mab879
Copy link
Member Author

Mab879 commented Mar 20, 2023

/packit build

Copy link
Contributor

@mildas mildas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why to disable package_avahi_removed when it doesn't conflict with GUI packages?

Looking at RHEL9 CIS Benchmark, I don't see avahi-autoipd mentioned at all. 2.2.2 Ensure Avahi Server is not installed (Automated) requires only avahi uninstalled. Why do we remove avahi-autoipd package?

@Mab879 Mab879 requested a review from a team as a code owner March 20, 2023 14:46
@Mab879
Copy link
Member Author

Mab879 commented Mar 20, 2023

Why to disable package_avahi_removed when it doesn't conflict with GUI packages?

Without creating another rule very similar rule I don't see how we can disable this remediation for only one profile.

Looking at RHEL9 CIS Benchmark, I don't see avahi-autoipd mentioned at all. 2.2.2 Ensure Avahi Server is not installed (Automated) requires only avahi uninstalled. Why do we remove avahi-autoipd package?

I have removed avahi-autoipd from the profile and the package doesn't seem to be in RHEL 9.

@openshift-ci
Copy link

openshift-ci bot commented Mar 20, 2023

@Mab879: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-rhcos4-high c3395ec link true /test e2e-aws-rhcos4-high
ci/prow/e2e-aws-rhcos4-moderate c3395ec link true /test e2e-aws-rhcos4-moderate
ci/prow/e2e-aws-rhcos4-e8 c3395ec link true /test e2e-aws-rhcos4-e8

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mildas
Copy link
Contributor

mildas commented Mar 20, 2023

Without creating another rule very similar rule I don't see how we can disable this remediation for only one profile.

I see. But I don't like disabling Anaconda remediation. Workstation users won't pass there and so we should think if the rule makes sense in CIS Workstation profile.
Do you think we could convince CIS that the requirement should be removed from Workstation L2 because of the conflict on RHEL9? Or if they could change the requirement to Avahi not installed or avahi-daemon disabled?

@Mab879
Copy link
Member Author

Mab879 commented Mar 20, 2023

Without creating another rule very similar rule I don't see how we can disable this remediation for only one profile.

I see. But I don't like disabling Anaconda remediation. Workstation users won't pass there and so we should think if the rule makes sense in CIS Workstation profile. Do you think we could convince CIS that the requirement should be removed from Workstation L2 because of the conflict on RHEL9? Or if they could change the requirement to Avahi not installed or avahi-daemon disabled?

I don't know if we could convince them to pull it its in L2, so some pain is expected. Moving to disabled might work, but again a level 2 requirement is expected to have some usability issues.

The package can be removed without incident once the installation is done. Which is why I pulled the Anaconda remediation.

A third option would be get libsane-hpaio a soft requirement.

My thought is that for now I will pull the rule from level II workstation profile as work on the other solution.

Mab879 added 2 commits March 21, 2023 14:06
Removal of this package causes issues with GUI kickstart installs.
@Mab879 Mab879 force-pushed the fix_10277_package branch from c3395ec to 4a84177 Compare March 21, 2023 19:58
@codeclimate
Copy link

codeclimate bot commented Mar 21, 2023

Code Climate has analyzed commit 4a84177 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 51.8% (0.0% change).

View more on Code Climate.

@mildas mildas self-assigned this Mar 22, 2023
@mildas mildas merged commit 5c6ea05 into ComplianceAsCode:master Mar 22, 2023
@Mab879 Mab879 deleted the fix_10277_package branch March 22, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs. CIS CIS Benchmark related. RHEL9 Red Hat Enterprise Linux 9 product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RHEL9 GUI Kickstart install of CIS Workstation Level 2 aborts
3 participants