-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn off avahi and avahi-autoipd fixes during install #10341
Conversation
5bc136b
to
089d929
Compare
/packit build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why to disable package_avahi_removed
when it doesn't conflict with GUI packages?
Looking at RHEL9 CIS Benchmark, I don't see avahi-autoipd
mentioned at all. 2.2.2 Ensure Avahi Server is not installed (Automated)
requires only avahi
uninstalled. Why do we remove avahi-autoipd
package?
Without creating another rule very similar rule I don't see how we can disable this remediation for only one profile.
I have removed |
@Mab879: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
linux_os/guide/services/avahi/disable_avahi_group/package_avahi-autoipd_removed/rule.yml
Outdated
Show resolved
Hide resolved
I see. But I don't like disabling Anaconda remediation. Workstation users won't pass there and so we should think if the rule makes sense in CIS Workstation profile. |
I don't know if we could convince them to pull it its in L2, so some pain is expected. Moving to disabled might work, but again a level 2 requirement is expected to have some usability issues. The package can be removed without incident once the installation is done. Which is why I pulled the Anaconda remediation. A third option would be get My thought is that for now I will pull the rule from level II workstation profile as work on the other solution. |
It is not in the benchmark
Removal of this package causes issues with GUI kickstart installs.
c3395ec
to
4a84177
Compare
Code Climate has analyzed commit 4a84177 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 51.8% (0.0% change). View more on Code Climate. |
Description:
Since gnome-desktop requires libsane-hpaio which requires avahi having avahi removed during the install of the OS causes the install to fail.
Rationale:
Fixes #10277