Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate xmldiff package upgrade problem. #10417 #10419

Merged

Conversation

ggbecker
Copy link
Member

@ggbecker ggbecker commented Apr 3, 2023

Mitigate xmldiff package upgrade problem.

Version 2.6 of this package triggers #10417 which blocks PRs to get merged. This fix is a temporary solution to unblock PRs.

Version 2.6 of this package triggers ComplianceAsCode#10417 which blocks PRs
to get merged. This fix is a temporary solution to unblock PRs.
@ggbecker ggbecker added this to the 0.1.68 milestone Apr 3, 2023
@ggbecker
Copy link
Member Author

ggbecker commented Apr 3, 2023

@Mab879 we need to merge this one ASAP to unblock other PRs to get merged.

@Mab879 Mab879 added the bugfix Fixes to reported bugs. label Apr 3, 2023
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the CI passes I will merge.

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879
Copy link
Member

Mab879 commented Apr 3, 2023

Can you please backport this to stabilization as well? We will have PRs that we don't want to block.

@codeclimate
Copy link

codeclimate bot commented Apr 3, 2023

Code Climate has analyzed commit 51c2235 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.4%.

View more on Code Climate.

@Mab879 Mab879 merged commit 5265361 into ComplianceAsCode:master Apr 3, 2023
@ggbecker ggbecker added the backported-into-stabilization PRs which were cherry-picked during stabilization process. label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported-into-stabilization PRs which were cherry-picked during stabilization process. bugfix Fixes to reported bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants