Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert package version enforcing for xmldiff in CI #10449

Merged

Conversation

ggbecker
Copy link
Member

Description:

  • Revert package version enforcing for xmldiff in CI.
    • This package was broken on 2.6.0 but there is a new 2.6.1 that should fix the issue with namespaces.

Rationale:

This package was broken on 2.6.0 but there is a new 2.6.1 that should
fix the issue with namespaces. Related to: ComplianceAsCode#10417
@ggbecker ggbecker added this to the 0.1.68 milestone Apr 11, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@jan-cerny jan-cerny self-assigned this Apr 11, 2023
@codeclimate
Copy link

codeclimate bot commented Apr 11, 2023

Code Climate has analyzed commit 1277672 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.4% (0.0% change).

View more on Code Climate.

@ggbecker
Copy link
Member Author

ggbecker commented Apr 11, 2023

the testing farm centos-stream-8 is failing on openscap with the following message:

E: oscap: Can't statvfs /proc/sys/fs/binfmt_misc: errno=19, No such device.

from: https://artifacts.dev.testing-farm.io/0b510569-66bf-417b-b5c5-68fa0371aae3/

Maybe @mildas can help with this one.

@jan-cerny
Copy link
Collaborator

@ggbecker @mildas

I was just reporting it

see #10450

Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen that the test python-unit-ssg-module passed on the Fedora latest in the CI and I have seen that xmldiff 2.6.1 from pip has been used in that run.

The testing-farm jobs fail is unrelated to the contents of this PR and is tracked in #10450 and we can waive it here.

@jan-cerny jan-cerny changed the title Revert package version enforcing for xmldiff in CI. Revert package version enforcing for xmldiff in CI Apr 11, 2023
@ggbecker
Copy link
Member Author

I'm going to merge it bypassing the requirements then. Thanks @jan-cerny

@ggbecker ggbecker merged commit 3e9cabf into ComplianceAsCode:master Apr 11, 2023
@jan-cerny
Copy link
Collaborator

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gating ctest on Fedora latest is failing on a ssg python module test
2 participants