-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add requirements.txt file #10473
Add requirements.txt file #10473
Conversation
Code Climate has analyzed commit a55b7eb and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 52.4% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for proposing this, Matt.
yamlpath | ||
json2html | ||
types-openpyxl | ||
types-PyYAML |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we'll need:
- PyYAML
- jinja2
- pandas (although this is from the tool I'm writing, so I can add it there if this lands first)
- tables
- openpyxl
- pygments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like all of those packages are in the Fedora repos (and most are in RHEL). The current scope of this PR is only for packages not in Fedora. These would be good add to your PR in #10474.
PyYAML -> python3-pyyaml
jinja2 - > python3-jinja2
pandas -> python3-pandas
tables -> python3-tables
That's not currently in our docs, can you cite which script needs this?
openpyxl -> python3-openpyxl
pygments -> python3-pygments
, also not in our docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok - good deal. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't be shy and add them as well - if you use pip install
on a system where part of the requirements are already satisfied, they are simply skipped.
Helps address #7988 |
I have a patch for introducing a test-requirements.txt file, too #10487 Another approach we could take to help keep dependencies orthogonal would be to group scripts in directories. For example, we could have From there, it would be relatively easy for contributors to have virtualenvs for dev and build separately (e.g., A side effect is that it would be nice to group like tools together, which may lead to efforts to consolidate functionality or consider moving to a unified, intuitive tool set for development. |
Succeed by #10487 |
Description:
Add a requirements.txt file with the Python packages that are not in the Fedora repos.
Rationale:
Make it easier to install the python dependacies.