Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix into ansible part of the rule audit_rules_suid_privilege_function #10510

Conversation

rumch-se
Copy link
Contributor

Description:

  • The PR makes a small correction into ansible part of the rule audit_rules_suid_privilege_function

Rationale:

  • In the existing version the execution of ansible playbook for remediation generates an error.

@openshift-ci
Copy link

openshift-ci bot commented Apr 28, 2023

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 28, 2023
@github-actions
Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
ansible remediation for rule 'xccdf_org.ssgproject.content_rule_audit_rules_suid_privilege_function' differs.
--- xccdf_org.ssgproject.content_rule_audit_rules_suid_privilege_function
+++ xccdf_org.ssgproject.content_rule_audit_rules_suid_privilege_function
@@ -41,6 +41,8 @@
 - name: Check the rules script being used
 command: grep '^ExecStartPost' /usr/lib/systemd/system/auditd.service
 register: check_rules_scripts_result
+ changed_when: false
+ failed_when: false
 when:
 - '"audit" in ansible_facts.packages'
 - ansible_virtualization_type not in ["docker", "lxc", "openvz", "podman", "container"]

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Apr 28, 2023

Code Climate has analyzed commit 31a6290 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.4% (0.0% change).

View more on Code Climate.

@marcusburghardt
Copy link
Member

/packit retest-failed

@marcusburghardt marcusburghardt self-assigned this Apr 28, 2023
@marcusburghardt marcusburghardt added the Ansible Ansible remediation update. label Apr 28, 2023
@marcusburghardt marcusburghardt added this to the 0.1.68 milestone Apr 28, 2023
@marcusburghardt
Copy link
Member

/packit build

1 similar comment
@Mab879
Copy link
Member

Mab879 commented Apr 28, 2023

/packit build

Copy link

@brett060102 brett060102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and thank you.

@marcusburghardt marcusburghardt merged commit b894ed2 into ComplianceAsCode:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ansible Ansible remediation update. needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants