-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rule aide_scan_notification for sle 15 #10620
Update rule aide_scan_notification for sle 15 #10620
Conversation
Hi @svet-se. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Code Climate has analyzed commit 8a90b8c and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 52.5% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look perfect to me, but my tests showed that remediations/oval checks are not behaving correct on my SLES15 setup. I observed two issues:
- explicit package dependency of
crontabs
, which looks not like a universal package name, for SUSE platforms, the correct package seem to becronie
.
@svet-se can you please double check with your setup.
@marcusburghardt if my theory is correct we might have same issue on other platforms also or I am missing something else in the picture? If it is generic problem across all platforms maybe it deserves an issue and dedicated PR :) ? - The oval checks verify for cron entries in
/var/spool/cron/root
and/etc/cron.(d|daily|weekly|monthly
, while the ansible cron procedure places the cron entry in a drop-in configuration file/var/spool/cron/tabs/root
. @marcusburghardt I am suspecting here again generic issue, what do you think?
@teacup-on-rockingchair I also noticed this, and communicate with maage who submitted this PR which added the crontabs logic (it affected other rules too). Will see if this will be fixed in the next PR-s, but IMHO this issue should be fixed in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description:
Rationale: