Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rule aide_scan_notification for sle 15 #10620

Conversation

svet-se
Copy link
Contributor

@svet-se svet-se commented May 23, 2023

Description:

  • Update rule aide_scan_notification for sle 15

Rationale:

  • Accoring DISA recommendations Version 1, Release 9 from 26 January 2023 about SLE 15 STIG - "SLES-15-010570 - Verify the SUSE operating system notifies the SA when AIDE discovers anomalies in the operation of any security functions"

@svet-se svet-se requested a review from a team as a code owner May 23, 2023 12:18
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label May 23, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 23, 2023

Hi @svet-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented May 23, 2023

Code Climate has analyzed commit 8a90b8c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.5% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 added SLES SUSE Linux Enterprise Server product related. STIG STIG Benchmark related. labels May 23, 2023
Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look perfect to me, but my tests showed that remediations/oval checks are not behaving correct on my SLES15 setup. I observed two issues:

  1. explicit package dependency of crontabs, which looks not like a universal package name, for SUSE platforms, the correct package seem to be cronie.
    @svet-se can you please double check with your setup.
    @marcusburghardt if my theory is correct we might have same issue on other platforms also or I am missing something else in the picture? If it is generic problem across all platforms maybe it deserves an issue and dedicated PR :) ?
  2. The oval checks verify for cron entries in /var/spool/cron/root and /etc/cron.(d|daily|weekly|monthly, while the ansible cron procedure places the cron entry in a drop-in configuration file /var/spool/cron/tabs/root. @marcusburghardt I am suspecting here again generic issue, what do you think?

@svet-se
Copy link
Contributor Author

svet-se commented May 25, 2023

@teacup-on-rockingchair I also noticed this, and communicate with maage who submitted this PR which added the crontabs logic (it affected other rules too). Will see if this will be fixed in the next PR-s, but IMHO this issue should be fixed in another PR.

Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@teacup-on-rockingchair teacup-on-rockingchair merged commit 27d74f6 into ComplianceAsCode:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. STIG STIG Benchmark related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants