Implement distributed product properties without applying them #10648
Conversation
... in which jinja2-aware yaml files can be used to define new properties.
Make sure that the original product attributes from product yaml are not overwritten by distributed product properties.
... that are unlikely to be able to use compiled product files.
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit 67d80f8 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 95.5% (50% is the threshold). This pull request will bring the total coverage in the repository to 52.8% (0.2% change). View more on Code Climate. |
jan-cerny
added
Highlight
There was a problem hiding this comment.
I have changed the difference between this PR and the original PR #10554. I have tried to introduce a YAML file to the /product_properties directory. I have tried to insert various values and each time rebuild the rhel9 product. I have seen that they appeared in the build/rhel9/product.yml . I have also tried to override some values defined in the product.yml and the build failed as expected. Thanks for the concise documentation.
Description:
The PR #10554 that went through some review already introduces product properties, and illustrates them on real properties and real products.
However, as touching products is relatively costly due to the need for approvals, I have carved out the functionality from the application, so this PR implements the functionality and tests, but it doesn't change anything.
Rationale:
Changes to product definitions can be accomplished more easily when they are not mixed with the build system code, so the split of the original PR into two makes some sense.
Review Hints:
See the #10554 to see the feature it in action, and diff the code.