Add audit_rules_login_events_faillock to RHEL 8 STIG #10816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The selection of the rule audit_rules_login_events_faillock has been commented out with a comment that the RHEL-08-020017 needs to be implemented first. But, the RHEL-08-020017 is now implemented by rule accounts_passwords_pam_faillock_dir, which didn't exist before. Therefore, we can uncomment the rule selection. The rule "accounts_passwords_pam_faillock_dir" sets the value of the `dir` configuration option to `/var/log/faillock` which is the value of the `faillock_path` product property. So, we only need to use the product property in the rule.yml. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2167999
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
jan-cerny
added
do-not-merge/work-in-progress
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit d0cfabc and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.5% (0.0% change). View more on Code Climate. |
marcusburghardt
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The selection of the rule audit_rules_login_events_faillock has been commented out with a comment that the RHEL-08-020017 needs to be implemented first. But, the RHEL-08-020017 is now implemented by rule accounts_passwords_pam_faillock_dir, which didn't exist before. Therefore, we can uncomment the rule selection.
The rule "accounts_passwords_pam_faillock_dir" sets the value of the
dirconfiguration option to/var/log/faillockwhich is the value of thefaillock_pathproduct property. So, we only need to use the product property in the rule.yml.Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2167999