Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include new kickstart files for CCN profiles #10863

Merged
merged 4 commits into from
Jul 18, 2023
Merged

Include new kickstart files for CCN profiles #10863

merged 4 commits into from
Jul 18, 2023

Conversation

marcusburghardt
Copy link
Member

@marcusburghardt marcusburghardt commented Jul 18, 2023 •
edited
Loading

Description:

Include three new rhel9 kickstart files for CCN profiles.

Rationale:

Easier to test CCN profiles.

Review Hints:

They were based on CIS kickstart files. I only updated the profile name at the end of the file and some comment lines.

@marcusburghardt marcusburghardt added the Test Suite Update in Test Suite. label Jul 18, 2023
@marcusburghardt marcusburghardt added this to the 0.1.69 milestone Jul 18, 2023
@marcusburghardt marcusburghardt requested a review from mildas July 18, 2023 09:06
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@vojtapolasek vojtapolasek self-assigned this Jul 18, 2023
vojtapolasek
vojtapolasek requested changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @marcusburghardt and thank you for the addition. I found just two small things in comments... no big deal but it could cause some confusion for users.

products/rhel9/kickstart/ssg-rhel9-ccn_basic-ks.cfg Outdated Show resolved Hide resolved
products/rhel9/kickstart/ssg-rhel9-ccn_intermediate-ks.cfg Outdated Show resolved Hide resolved
@marcusburghardt @vojtapolasek
Apply suggestions from code review
0e4ebd7 
Updated profile level in comments of respective kickstart files

Co-authored-by: vojtapolasek <[email protected]>
@marcusburghardt
Copy link
Member Author

Hello @marcusburghardt and thank you for the addition. I found just two small things in comments... no big deal but it could cause some confusion for users.

Suggestions committed.

@codeclimate
Copy link

codeclimate bot commented Jul 18, 2023

Code Climate has analyzed commit 0e4ebd7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.3% (0.0% change).

View more on Code Climate.

vojtapolasek
vojtapolasek approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thank you.

@vojtapolasek vojtapolasek merged commit 83b0162 into ComplianceAsCode:master Jul 18, 2023
@marcusburghardt marcusburghardt deleted the ccn_ks_rhel9 branch July 18, 2023 12:24
@marcusburghardt marcusburghardt added the CCN CCN Benchmark related. label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vojtapolasek vojtapolasek vojtapolasek approved these changes

@mildas mildas Awaiting requested review from mildas

Assignees

@vojtapolasek vojtapolasek

Labels
CCN CCN Benchmark related. Test Suite Update in Test Suite.
Projects
None yet
Milestone
0.1.69
Development

Successfully merging this pull request may close these issues.
2 participants
@marcusburghardt @vojtapolasek