Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tickets from CIS control files #10869

Merged

Conversation

rhmdnd
Copy link
Collaborator

@rhmdnd rhmdnd commented Jul 18, 2023

We attempted to use tickets to document WIP changes for a control, but
it appears to break content builds.

Commenting out the attribute for now so we can at least build the CIS
profile.

This is related to issue #10868.

We attempted to use `tickets` to document WIP changes for a control, but
it appears to break content builds.

Commenting out the attribute for now so we can at least build the CIS
profile.

This is related to issue ComplianceAsCode#10868.
@rhmdnd
Copy link
Collaborator Author

rhmdnd commented Jul 18, 2023

/test e2e-aws-ocp4-cis
/test e2e-aws-ocp4-cis-node

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@rhmdnd
Copy link
Collaborator Author

rhmdnd commented Jul 18, 2023

Running the CIS CI won't make much of a difference here since we're not using that control file, yet.

So long as the build CI works, this should be OK.

@rhmdnd rhmdnd added OpenShift OpenShift product related. CIS CIS Benchmark related. labels Jul 18, 2023
@rhmdnd rhmdnd requested a review from jhrozek July 18, 2023 15:24
@codeclimate
Copy link

codeclimate bot commented Jul 18, 2023

Code Climate has analyzed commit b62134c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.2% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@Vincent056 Vincent056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rhmdnd rhmdnd merged commit a8e76fb into ComplianceAsCode:master Jul 18, 2023
@Mab879 Mab879 added this to the 0.1.70 milestone Jul 18, 2023
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. OpenShift OpenShift product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants