Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-16877: Check for etcd pod specification in /etc/kubernetes/manifests #10964

Merged

Conversation

yuumasato
Copy link
Member

Description:

  • Change the path where the etcd pod specification file is checked to /etc/kubernetes/manifests/etcd-pod.yaml

Rationale:

  • This aligns the rules with items 1.1.7 and 1.1.8 in CIS 1.4.0.

  • Fixes OCPBUGS-16877

This aligns the rules with items 1.1.7 and 1.1.8 in CIS 1.4.0.
@yuumasato yuumasato added OpenShift OpenShift product related. CIS CIS Benchmark related. labels Aug 8, 2023
@yuumasato
Copy link
Member Author

/test e2e-aws-ocp4-cis
/test e2e-aws-ocp4-cis-node

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Start a new ephemeral environment with changes proposed in this pull request:

ocp4 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@rhmdnd
Copy link
Collaborator

rhmdnd commented Aug 8, 2023

/jira refresh

@codeclimate
Copy link

codeclimate bot commented Aug 8, 2023

Code Climate has analyzed commit d2142f5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.3% (0.0% change).

View more on Code Climate.

@yuumasato
Copy link
Member Author

/retest

Copy link
Collaborator

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rhmdnd rhmdnd merged commit c593828 into ComplianceAsCode:master Aug 9, 2023
@yuumasato yuumasato deleted the update_etcd_member_checks branch August 30, 2023 09:39
@Mab879 Mab879 added this to the 0.1.70 milestone Sep 14, 2023
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. OpenShift OpenShift product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants