OCP4: Fix e2e result on OCP 4.14 changes #11207

Vincent056 · 2023-10-17T07:10:49Z

Some of the file permission issues has been addressed on OpenShift 4.14 from 644 to 600 , let's change the expected e2e result to match that

github-actions · 2023-10-17T07:12:32Z

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment

Oracle Linux 8 Environment

Vincent056 · 2023-10-17T14:42:34Z

/test ocp-cis

openshift-ci · 2023-10-17T14:42:37Z

@Vincent056: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aws-ocp4-cis
/test e2e-aws-ocp4-cis-node
/test e2e-aws-ocp4-e8
/test e2e-aws-ocp4-high
/test e2e-aws-ocp4-high-node
/test e2e-aws-ocp4-moderate
/test e2e-aws-ocp4-moderate-node
/test e2e-aws-ocp4-pci-dss
/test e2e-aws-ocp4-pci-dss-node
/test e2e-aws-ocp4-stig
/test e2e-aws-ocp4-stig-node
/test e2e-aws-rhcos4-e8
/test e2e-aws-rhcos4-high
/test e2e-aws-rhcos4-moderate
/test e2e-aws-rhcos4-stig
/test images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-ComplianceAsCode-content-master-images

In response to this:

/test ocp-cis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Vincent056 · 2023-10-17T14:45:25Z

/test e2e-aws-ocp4-high
/test e2e-aws-ocp4-high-node

yuumasato · 2023-10-31T16:35:08Z

applications/openshift/master/file_permissions_controller_manager_kubeconfig/tests/ocp4/4.6.yml

Do we need e2e test files for 4.6, 4.7, 4.8 and 4.9?

no, they are out of support cycle

...ications/openshift/master/file_permissions_controller_manager_kubeconfig/tests/ocp4/4.13.yml

Vincent056 · 2023-11-02T08:17:12Z

/test e2e-aws-ocp4-high
/test e2e-aws-ocp4-high-node

rhmdnd · 2023-11-02T14:27:13Z

/test e2e-aws-ocp4-high-node

rhmdnd · 2023-11-02T21:08:13Z

Looks like we have a legitimate failure;

     helpers.go:808: Result - Name: e2e-high-node-master-file-permissions-etcd-member - Status: PASS - Severity: medium
    helpers.go:815: E2E-FAILURE: The expected result for the file_permissions_etcd_member rule didn't match. Expected 'map[master:FAIL worker:NOT-APPLICABLE]', Got 'PASS'
    helpers.go:808: Result - Name: e2e-high-node-master-file-permissions-etcd-pki-cert-files - Status: PASS - Severity: medium
    helpers.go:881: Rule file_permissions_etcd_pki_cert_files matched expected result
    helpers.go:808: Result - Name: e2e-high-node-master-file-permissions-ip-allocations - Status: NOT-APPLICABLE - Severity: medium
    helpers.go:808: Result - Name: e2e-high-node-master-file-permissions-kube-apiserver - Status: PASS - Severity: medium
    helpers.go:815: E2E-FAILURE: The expected result for the file_permissions_kube_apiserver rule didn't match. Expected 'map[master:FAIL worker:NOT-APPLICABLE]', Got 'PASS'

yuumasato · 2023-11-13T15:20:23Z

applications/openshift/master/file_permissions_etcd_member/tests/ocp4/4.7.yml

There are still test files for 4.7, 4.8, 4.9 and 4.10.

yuumasato · 2023-11-13T15:20:50Z

applications/openshift/master/file_permissions_etcd_member/tests/ocp4/4.10.yml

Maintenance for 4.10 ended September 10, 2023

yuumasato · 2023-11-14T14:29:21Z

applications/openshift/master/file_permissions_kube_apiserver/tests/ocp4/4.13.yml

@@ -0,0 +1,4 @@
+---
+default_result:
+  master: FAIL


From what I could test this rule is passing on OCP 4.13

that's correct

yuumasato · 2023-11-14T14:30:31Z

applications/openshift/master/file_permissions_etcd_member/tests/ocp4/4.13.yml

@@ -0,0 +1,4 @@
+---
+default_result:
+  master: FAIL


This rule was passing on the 4.13 cluster I got.

that's correct, sorry I missed it

yuumasato · 2023-11-14T15:11:50Z

Looks like we have a legitimate failure;

     helpers.go:808: Result - Name: e2e-high-node-master-file-permissions-etcd-member - Status: PASS - Severity: medium
    helpers.go:815: E2E-FAILURE: The expected result for the file_permissions_etcd_member rule didn't match. Expected 'map[master:FAIL worker:NOT-APPLICABLE]', Got 'PASS'
    helpers.go:808: Result - Name: e2e-high-node-master-file-permissions-etcd-pki-cert-files - Status: PASS - Severity: medium
    helpers.go:881: Rule file_permissions_etcd_pki_cert_files matched expected result
    helpers.go:808: Result - Name: e2e-high-node-master-file-permissions-ip-allocations - Status: NOT-APPLICABLE - Severity: medium
    helpers.go:808: Result - Name: e2e-high-node-master-file-permissions-kube-apiserver - Status: PASS - Severity: medium
    helpers.go:815: E2E-FAILURE: The expected result for the file_permissions_kube_apiserver rule didn't match. Expected 'map[master:FAIL worker:NOT-APPLICABLE]', Got 'PASS'

It looks like the CI test was ran on OCP 4.13?
INFO[2023-11-02T14:27:23Z] Building release latest from a snapshot of ocp/4.13

Can you confirm that?

Some of the file permission issues has been addressed on OpenShift 4.14 from 644 to 600 and some of them are back ported to 4.13, let's change the expected e2e result to match that

Vincent056 · 2023-11-28T16:17:43Z

Looks like we have a legitimate failure;

     helpers.go:808: Result - Name: e2e-high-node-master-file-permissions-etcd-member - Status: PASS - Severity: medium
    helpers.go:815: E2E-FAILURE: The expected result for the file_permissions_etcd_member rule didn't match. Expected 'map[master:FAIL worker:NOT-APPLICABLE]', Got 'PASS'
    helpers.go:808: Result - Name: e2e-high-node-master-file-permissions-etcd-pki-cert-files - Status: PASS - Severity: medium
    helpers.go:881: Rule file_permissions_etcd_pki_cert_files matched expected result
    helpers.go:808: Result - Name: e2e-high-node-master-file-permissions-ip-allocations - Status: NOT-APPLICABLE - Severity: medium
    helpers.go:808: Result - Name: e2e-high-node-master-file-permissions-kube-apiserver - Status: PASS - Severity: medium
    helpers.go:815: E2E-FAILURE: The expected result for the file_permissions_kube_apiserver rule didn't match. Expected 'map[master:FAIL worker:NOT-APPLICABLE]', Got 'PASS'

It looks like the CI test was ran on OCP 4.13? INFO[2023-11-02T14:27:23Z] Building release latest from a snapshot of ocp/4.13

Can you confirm that?

yes we are running on 4.13

Vincent056 · 2023-11-28T16:18:08Z

/test e2e-aws-ocp4-high-node

codeclimate · 2023-11-28T16:29:45Z

Code Climate has analyzed commit ec4735f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5%.

View more on Code Climate.

Vincent056 · 2023-11-28T20:31:00Z

/test e2e-aws-ocp4-high-node

rhmdnd

/lgtm

yuumasato · 2023-11-29T09:41:37Z

Merging despite failures of testing-farm:centos-stream-8-x86_64 and testing-farm:centos-stream-9-x86_64 .
The tests are passing but overall result is WARN which is flagging them as fail.
Moreover, they are not directly related to OCP4.

yuumasato reviewed Oct 31, 2023

View reviewed changes

Vincent056 force-pushed the 4_14_change branch from 3d70354 to 34e8a2b Compare November 2, 2023 08:16

marcusburghardt added the OpenShift OpenShift product related. label Nov 8, 2023

yuumasato reviewed Nov 14, 2023

View reviewed changes

OCP4: Fix e2e result on CIS kube file permission issues

ec4735f

Some of the file permission issues has been addressed on OpenShift 4.14 from 644 to 600 and some of them are back ported to 4.13, let's change the expected e2e result to match that

Vincent056 force-pushed the 4_14_change branch from 34e8a2b to ec4735f Compare November 28, 2023 16:16

rhmdnd approved these changes Nov 28, 2023

View reviewed changes

rhmdnd mentioned this pull request Nov 29, 2023

Add profile aliases for OpenShift versioned profiles #11241

Merged

vojtapolasek added this to the 0.1.72 milestone Nov 29, 2023

yuumasato approved these changes Nov 29, 2023

View reviewed changes

yuumasato merged commit 49d1527 into ComplianceAsCode:master Nov 29, 2023
32 of 34 checks passed

Mab879 added the Test Suite Update in Test Suite. label Nov 30, 2023

marcusburghardt assigned yuumasato Dec 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCP4: Fix e2e result on OCP 4.14 changes #11207

OCP4: Fix e2e result on OCP 4.14 changes #11207

Vincent056 commented Oct 17, 2023 •

edited

Loading

github-actions bot commented Oct 17, 2023

Vincent056 commented Oct 17, 2023

openshift-ci bot commented Oct 17, 2023

Vincent056 commented Oct 17, 2023

yuumasato Oct 31, 2023

Vincent056 Oct 31, 2023

Vincent056 commented Nov 2, 2023

rhmdnd commented Nov 2, 2023

rhmdnd commented Nov 2, 2023

yuumasato Nov 13, 2023

yuumasato Nov 13, 2023

yuumasato Nov 14, 2023

Vincent056 Nov 28, 2023

yuumasato Nov 14, 2023

Vincent056 Nov 28, 2023

yuumasato commented Nov 14, 2023

Vincent056 commented Nov 28, 2023

Vincent056 commented Nov 28, 2023

codeclimate bot commented Nov 28, 2023

Vincent056 commented Nov 28, 2023

rhmdnd left a comment

yuumasato commented Nov 29, 2023

OCP4: Fix e2e result on OCP 4.14 changes #11207

OCP4: Fix e2e result on OCP 4.14 changes #11207

Conversation

Vincent056 commented Oct 17, 2023 • edited Loading

github-actions bot commented Oct 17, 2023

Vincent056 commented Oct 17, 2023

openshift-ci bot commented Oct 17, 2023

Vincent056 commented Oct 17, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Vincent056 commented Nov 2, 2023

rhmdnd commented Nov 2, 2023

rhmdnd commented Nov 2, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yuumasato commented Nov 14, 2023

Vincent056 commented Nov 28, 2023

Vincent056 commented Nov 28, 2023

codeclimate bot commented Nov 28, 2023

Vincent056 commented Nov 28, 2023

rhmdnd left a comment

Choose a reason for hiding this comment

yuumasato commented Nov 29, 2023

Vincent056 commented Oct 17, 2023 •

edited

Loading