Fix duplicate OVAL ids (gpgkey package, GDM login)

[evgenyz]

Description:

• These rules share same IDs in their OVAL sub-components. If they ever meet in the same DS conflict is imminent.

Rationale:

• The only thing that prevents them from colliding is prodtype. As we are going to get rid of it we shall get prepared.

Review Hints:

• The gnome_gdm_disable_unattended_automatic_login rule is in conflicts with gnome_gdm_disable_automatic_login.

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)

Fedora Testing Environment

Oracle Linux 8 Environment

[github-actions]

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff

OVAL for rule 'xccdf_org.ssgproject.content_rule_ensure_redhat_gpgkey_installed' differs.
--- oval:ssg-ensure_redhat_gpgkey_installed:def:1
+++ oval:ssg-ensure_redhat_gpgkey_installed:def:1
@@ -2,9 +2,9 @@
 criteria AND
 criteria OR
 extend_definition oval:ssg-installed_OS_is_rhel8:def:1
-criterion oval:ssg-test_package_gpgkey-fd431d51-4ae0493b_installed:tst:1
+criterion oval:ssg-test_redhat_package_gpgkey-fd431d51-4ae0493b_installed:tst:1
 criteria OR
-criterion oval:ssg-test_package_gpgkey-d4082792-5b32db75_installed:tst:1
+criterion oval:ssg-test_redhat_package_gpgkey-d4082792-5b32db75_installed:tst:1
 criteria AND
 extend_definition oval:ssg-installed_OS_is_centos8:def:1
-criterion oval:ssg-test_package_gpgkey-8483c65d-5ccc5b19_installed:tst:1
+criterion oval:ssg-test_redhat_package_gpgkey-8483c65d-5ccc5b19_installed:tst:1

[codeclimate]

Code Climate has analyzed commit 7587a45 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5% (0.0% change).

View more on Code Climate.

[evgenyz]

By the look of it test results are bogus. Changes should not affect Bash or Ansible code.

[Mab879]

/packit retest-failed

[Mab879]

By the look of it test results are bogus. Changes should not affect Bash or Ansible code.

Agreed. After checking master the test results for ensure_redhat_gpgkey_installed are the same.

I have created #11380 to track the issue with the Ansible tests.

[Mab879]

LGTM.

Thanks.