-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align RHEL 7 CIS control file with CIS v4.0.0 - Section 5 #11456
Align RHEL 7 CIS control file with CIS v4.0.0 - Section 5 #11456
Conversation
Skipping CI for Draft Pull Request. |
41098a4
to
0d22624
Compare
The CI fail on Rawhide is caused by aio-libs/multidict#926 and isn't related to the pull request. |
This datastream diff is auto generated by the check Click here to see the full diffbash remediation for rule 'xccdf_org.ssgproject.content_rule_auditd_data_retention_space_left_action' differs.
--- xccdf_org.ssgproject.content_rule_auditd_data_retention_space_left_action
+++ xccdf_org.ssgproject.content_rule_auditd_data_retention_space_left_action
@@ -4,6 +4,7 @@
var_auditd_space_left_action=''
+var_auditd_space_left_action="$(echo $var_auditd_space_left_action | cut -d \| -f 1)"
#
# If space_left_action present in /etc/audit/auditd.conf, change value
# to var_auditd_space_left_action, else
ansible remediation for rule 'xccdf_org.ssgproject.content_rule_auditd_data_retention_space_left_action' differs.
--- xccdf_org.ssgproject.content_rule_auditd_data_retention_space_left_action
+++ xccdf_org.ssgproject.content_rule_auditd_data_retention_space_left_action
@@ -28,7 +28,7 @@
- name: Configure auditd space_left Action on Low Disk Space
lineinfile:
dest: /etc/audit/auditd.conf
- line: space_left_action = {{ var_auditd_space_left_action }}
+ line: space_left_action = {{ var_auditd_space_left_action.split('|')[0] }}
regexp: ^\s*space_left_action\s*=\s*.*$
state: present
create: true
New content has different text for rule 'xccdf_org.ssgproject.content_rule_package_systemd-journal-remote_installed'.
--- xccdf_org.ssgproject.content_rule_package_systemd-journal-remote_installed
+++ xccdf_org.ssgproject.content_rule_package_systemd-journal-remote_installed
@@ -14,3 +14,6 @@
Storing log data on a remote host protects log integrity from local
attacks. If an attacker gains root access on the local system, they
could tamper with or remove log data that is stored on the local system.
+
+[ident]:
+CCE-86467-8
ansible remediation for rule 'xccdf_org.ssgproject.content_rule_package_systemd-journal-remote_installed' differs.
--- xccdf_org.ssgproject.content_rule_package_systemd-journal-remote_installed
+++ xccdf_org.ssgproject.content_rule_package_systemd-journal-remote_installed
@@ -4,6 +4,7 @@
state: present
when: ansible_virtualization_type not in ["docker", "lxc", "openvz", "podman", "container"]
tags:
+ - CCE-86467-8
- enable_strategy
- low_complexity
- low_disruption |
Add support for pipe character separated values of the variables. We started to use the pipe character separated values in RHEL 7 CIS where we set `var_auditd_space_left_action` to `email|exec|single|halt`. This change is similar to code that we have in rule `auditd_data_disk_full_action`.
Add support for pipe character separated values of the variables. We started to use the pipe character separated values in RHEL 7 CIS where we set `var_auditd_space_left_action` to `email|exec|single|halt`. This change is similar to code that we have in rule `auditd_data_disk_full_action`.
e587adb
to
24d9d20
Compare
I have rebased this PR on the top of the latest upstream master branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. I only have some few comments to take a look.
linux_os/guide/system/logging/journald/package_systemd-journal-remote_installed/rule.yml
Show resolved
Hide resolved
I have done changes according to @marcusburghardt's comments. |
controls/cis_rhel7.yml
Outdated
levels: | ||
- l1_server | ||
- l1_workstation | ||
status: partial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The status now can be updated to automated
and the comment can be removed.
I have updated the status and removed the comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Thanks for the nice work @jan-cerny . I will wait the CI tests to confirm everything is good and merge it.
Code Climate has analyzed commit a7860dc and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.5% (0.0% change). View more on Code Climate. |
I checked the failed Automatus tests and they are failing during the clean-up, after the rule tests. We are investigating the issue with automatus task "Delete datastream artifact". |
86ccadb
into
ComplianceAsCode:master
Description:
In this PR, we change the control file, change references, add existing rules. But, we don't add new rules.
Rationale:
Align RHEL 7 CIS control file with CIS v4.0.0
Review Hints: