-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review CIS RHEL8 v3.0.0 Section 3 #11469
Review CIS RHEL8 v3.0.0 Section 3 #11469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @Mab879 . I have some minor comments about titles and some considerations about references.
- l1_workstation | ||
status: automated | ||
rules: | ||
- set_firewalld_default_zone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove the cis@rhel8
references on these rules no longer mentioned in the control file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I can still see cis@rhel8:
references in rule no longer mentioned in control file.
Basically are rules removed by this commit 8f140f6
We can try to clean-up this after, but doing it now would be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is almost ready except for few more issues related to references. They could even be fixed in another smaller PR without problem, but unfortunately the profile stability test is also failing so we can't merge it.
linux_os/guide/services/ssh/ssh_server/sshd_enable_warning_banner/rule.yml
Outdated
Show resolved
Hide resolved
…d for RHEL 8 CIS Closes ComplianceAsCode#5246
34cb367
to
908eb8a
Compare
Code Climate has analyzed commit 908eb8a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.5% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Thanks @Mab879
8f3f429
into
ComplianceAsCode:master
Description:
Review the cis_rhel8.yml control file and update section 3 networking in alignment to CIS RHEL 8 v3.0.0.
Rationale:
Keep RHEL 8 profiles updated with CIS RHEL 8 last version.