Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review CIS RHEL8 v3.0.0 Section 3 #11469

Merged
merged 36 commits into from
Jan 26, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jan 24, 2024

Description:

Review the cis_rhel8.yml control file and update section 3 networking in alignment to CIS RHEL 8 v3.0.0.

Rationale:

Keep RHEL 8 profiles updated with CIS RHEL 8 last version.

@Mab879 Mab879 added Update Profile Issues or pull requests related to Profiles updates. RHEL8 Red Hat Enterprise Linux 8 product related. CIS CIS Benchmark related. labels Jan 24, 2024
@Mab879 Mab879 requested a review from a team as a code owner January 24, 2024 16:18
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@marcusburghardt marcusburghardt self-assigned this Jan 25, 2024
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @Mab879 . I have some minor comments about titles and some considerations about references.

controls/cis_rhel8.yml Outdated Show resolved Hide resolved
controls/cis_rhel8.yml Outdated Show resolved Hide resolved
controls/cis_rhel8.yml Outdated Show resolved Hide resolved
- l1_workstation
status: automated
rules:
- set_firewalld_default_zone
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the cis@rhel8 references on these rules no longer mentioned in the control file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already removed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I can still see cis@rhel8: references in rule no longer mentioned in control file.
Basically are rules removed by this commit 8f140f6

We can try to clean-up this after, but doing it now would be good.

controls/cis_rhel8.yml Outdated Show resolved Hide resolved
controls/cis_rhel8.yml Show resolved Hide resolved
controls/cis_rhel8.yml Outdated Show resolved Hide resolved
controls/cis_rhel8.yml Outdated Show resolved Hide resolved
controls/cis_rhel8.yml Show resolved Hide resolved
@marcusburghardt marcusburghardt added this to the 0.1.72 milestone Jan 25, 2024
controls/cis_rhel8.yml Outdated Show resolved Hide resolved
controls/cis_rhel8.yml Outdated Show resolved Hide resolved
controls/cis_rhel8.yml Outdated Show resolved Hide resolved
controls/cis_rhel8.yml Show resolved Hide resolved
controls/cis_rhel8.yml Outdated Show resolved Hide resolved
controls/cis_rhel8.yml Show resolved Hide resolved
controls/cis_rhel8.yml Show resolved Hide resolved
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is almost ready except for few more issues related to references. They could even be fixed in another smaller PR without problem, but unfortunately the profile stability test is also failing so we can't merge it.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label Jan 25, 2024
@Mab879 Mab879 force-pushed the rhel_8_cis_section_3 branch from 34cb367 to 908eb8a Compare January 25, 2024 22:55
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label Jan 25, 2024
Copy link

codeclimate bot commented Jan 25, 2024

Code Climate has analyzed commit 908eb8a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5% (0.0% change).

View more on Code Climate.

Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks @Mab879

@marcusburghardt marcusburghardt merged commit 8f3f429 into ComplianceAsCode:master Jan 26, 2024
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. RHEL8 Red Hat Enterprise Linux 8 product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants