Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update audit_ospp_general #11519

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Update audit_ospp_general #11519

merged 3 commits into from
Feb 6, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jan 31, 2024 •
edited
Loading

Description:

Update audit_ospp_general

Rationale:

Fixes #11517

@Mab879 Mab879 added Update Rule Issues or pull requests related to Rules updates. OSPP OSPP benchmark related. labels Jan 31, 2024
@Mab879 Mab879 added this to the 0.1.72 milestone Jan 31, 2024
@github-actions GitHub Actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 added the backported-into-stabilization PRs which were cherry-picked during stabilization process. label Jan 31, 2024
@Mab879 Mab879 mentioned this pull request Jan 31, 2024
Merged
vojtapolasek
vojtapolasek requested changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
I think changes look good, but note that there are other audit_ospp_general_* rules which are specific for other architectures. I think they should be updated as well.

Mab879 added 2 commits February 1, 2024 09:36
@Mab879
Update audit_ospp_general_aarch64
66fdb8a 
The file has been updated in RHEL and thus we need to update our
content.
@Mab879
Update audit_ospp_general_ppc64le
7555a74 
The file has been updated in RHEL and thus we need to update our
content.
@Mab879 Mab879 requested a review from vojtapolasek February 1, 2024 15:48
@codeclimate CodeClimate
Copy link

codeclimate bot commented Feb 1, 2024

Code Climate has analyzed commit 7555a74 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.3% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt self-assigned this Feb 2, 2024
marcusburghardt
marcusburghardt approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Mab879

@vojtapolasek vojtapolasek merged commit 2c9d3d5 into ComplianceAsCode:master Feb 6, 2024
43 checks passed
@Mab879 Mab879 deleted the fix11517 branch February 6, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusburghardt marcusburghardt marcusburghardt approved these changes

@vojtapolasek vojtapolasek vojtapolasek approved these changes

Assignees

@marcusburghardt marcusburghardt

Labels
backported-into-stabilization PRs which were cherry-picked during stabilization process. OSPP OSPP benchmark related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Milestone
0.1.72
Development

Successfully merging this pull request may close these issues.

audit_ospp_general rule content is misaligned
3 participants
@Mab879 @vojtapolasek @marcusburghardt