-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCP4: use utf-8 as default xml encoding #11614
Conversation
This commit make UTF-8 as default xml encoding. In a recent change, when writing xccdf xml file, it uses the output encoding US-ASCII as default if not set, however this causes issues in Compliance Operator parser, using US-ASCII, the parser is not able to get the prefix of xml node, therefore crash the parser pod.
/test 4.15-e2e-aws-ocp4-stig |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
Code Climate has analyzed commit ace1a53 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.1% (0.0% change). View more on Code Climate. |
AWS quota hit |
/test e2e-aws-ocp4-stig |
/test 4.15-e2e-aws-ocp4-stig |
/packit build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Pushing the thin DS PR content image results in CrashLoopBackOff
:
$ utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11549
But this PR's image works fine:
$ utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11614
@jan-cerny @Honny1 Do you guys have any objection to this change? |
@yuumasato I have no objection. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This commit make UTF-8 as default xml encoding. In a recent change to the build system, xml encoding was changed from not specific(UTF-8) to US-ASCII .
When writing XCCDF XML file, python xml uses the output encoding US-ASCII as default if not set, however this causes issues in Compliance Operator parser, using US-ASCII, the parser is not able to get the prefix of xml node, therefore crash the parser pod.
snippet of XCCDF print out using utf-8
parsed into
snippet of XCCDF print out using us-ascii parsed into: