Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCP4: Fix rules with both platform and platforms #11760

Merged
merged 1 commit into from
Mar 28, 2024
Merged

OCP4: Fix rules with both platform and platforms #11760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions applications/openshift/api-server/api_server_api_priority_gate_enabled/rule.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ rationale: |-
identifiers:
cce@ocp4: CCE-83656-9

platforms:
- ocp4.6


severity: medium

Expand All @@ -40,7 +39,7 @@ references:
pcidss: Req-2.2
srg: SRG-APP-000516-CTR-001325

platform: not ocp4-on-hypershift-hosted
platform: not ocp4-on-hypershift-hosted and ocp4.6

ocil_clause: '<tt>.apiServerArguments["feature-gates"]</tt> does not include <tt>APIPriorityAndFairness</tt>'

Expand Down
3 changes: 3 additions & 0 deletions applications/openshift/api-server/api_server_api_priority_gate_enabled/tests/ocp4/4.12.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
default_result: NOT-APPLICABLE

3 changes: 3 additions & 0 deletions applications/openshift/api-server/api_server_api_priority_gate_enabled/tests/ocp4/4.13.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
default_result: NOT-APPLICABLE

3 changes: 3 additions & 0 deletions applications/openshift/api-server/api_server_api_priority_gate_enabled/tests/ocp4/4.14.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
default_result: NOT-APPLICABLE

3 changes: 3 additions & 0 deletions applications/openshift/api-server/api_server_api_priority_gate_enabled/tests/ocp4/4.15.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
default_result: NOT-APPLICABLE

3 changes: 3 additions & 0 deletions applications/openshift/api-server/api_server_api_priority_gate_enabled/tests/ocp4/4.16.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
default_result: NOT-APPLICABLE

5 changes: 1 addition & 4 deletions applications/openshift/scheduler/scheduler_no_bind_address/rule.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,9 @@ references:
identifiers:
cce@ocp4: CCE-83674-2

platforms:
- ocp4.8 or ocp4.9

severity: medium

platform: not ocp4-on-hypershift-hosted
platform: not ocp4-on-hypershift-hosted and (ocp4.8 or ocp4.9)

ocil_clause: '<tt>kube-scheduler-pod</tt> sets --bind-address'

Expand Down
3 changes: 3 additions & 0 deletions applications/openshift/scheduler/scheduler_no_bind_address/tests/ocp4/4.14.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
default_result: NOT-APPLICABLE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these are used since the rule isn't included in any profiles (just the default one).


3 changes: 3 additions & 0 deletions applications/openshift/scheduler/scheduler_no_bind_address/tests/ocp4/4.15.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
default_result: NOT-APPLICABLE

3 changes: 3 additions & 0 deletions applications/openshift/scheduler/scheduler_no_bind_address/tests/ocp4/4.16.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
default_result: NOT-APPLICABLE

Loading