-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix package name for libpam-pkcs11 on Ubuntu #11854
Conversation
Hi @mpurg. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
Run |
1d0d13b
to
2da61cd
Compare
@Mab879 I added the changes made to |
2da61cd
to
ae07d5b
Compare
/packit build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
/packit build |
2 similar comments
/packit build |
/packit build |
@mpurg could you please rebase this PR for the tests to get unstuck |
ae07d5b
to
c79ac70
Compare
@dodys rebased |
Code Climate has analyzed commit c79ac70 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
/packit test |
/packit build |
Description:
smartcard_configure_cert_checking
on Ubuntu (UBTU-22-612025), which relies oninstall_smartcard_packages
and possibly other rules as well.