-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include product property in profile class #12050
Include product property in profile class #12050
Conversation
All profiles have a product and having this property defined in profile object is very helpful to collect and classify stats from profiles.
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
Code Climate has analyzed commit f5656d1 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have add a print statement to the ctor and I have executed most-used-rules and most-used-components subcommand.
This change doesn't affect the failed CI tests with CS8. They can be safely waived. |
The fail of TF on CS 8 isn't caused by this PR but is caused by the CS 8 sunset. |
Description:
All profiles have a product and having this property defined in profile object is very helpful to collect and classify stats from profiles.
Rationale:
Makes it easier to classify stats from profiles.