-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-33945: select required SSHD timeout rule #12091
OCPBUGS-33945: select required SSHD timeout rule #12091
Conversation
/test e2e-aws-rhcos4-high |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
729a3eb
to
f386a43
Compare
/test e2e-aws-rhcos4-high |
1 similar comment
/test e2e-aws-rhcos4-high |
The rule sshd_set_idle_timeout used to require rule sshd_set_keepalive_0 for Red Hat linuxes. But after ComplianceAsCode#11815 it started to require rules sshd_set_keepalive. This selects the rule that satifyes the requirement.
Add e2e for sshd-set-idle-timeout and replace sshd-set-keepalive-0 with sshd-set-keepalive.
d0b0aba
to
53fbc4f
Compare
/test e2e-aws-rhcos4-high |
Code Climate has analyzed commit 53fbc4f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description:
sshd_set_idle_timeout
used to require rulesshd_set_keepalive_0
for Red Hat linuxes.But after Set the
requires
tosshd_set_keepalive
onsshd_set_idle_timeout
#11815 it started to require rulessshd_set_keepalive
.This selects the rule that satifyes the requirement.
Rationale:
high
andmoderate
profiles.Review Hints:
sshd_set_idle_timeout
appears after ``rhcos4-highor
rhcos4-moderate`.