Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix automatus podman #12230

Merged
merged 6 commits into from
Aug 12, 2024

Conversation

alanmcanonical
Copy link
Contributor

Description:

  • Create test_suite-ubuntu2204
  • Fix the container sshd problem

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jul 29, 2024
Copy link

openshift-ci bot commented Jul 29, 2024

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

github-actions bot commented Jul 29, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jul 29, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12230
This image was built from commit: a698789

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12230

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12230 make deploy-local

@marcusburghardt marcusburghardt added Test Suite Update in Test Suite. Ubuntu Ubuntu product related. labels Jul 29, 2024
@jan-cerny
Copy link
Collaborator

In the logs we can see that the problem is No profile matching suffix "(all)" was found. Get available profiles using. I think that it might be caused by the prehistoric version of OpenSCAP, but I don't remember from the top of my head in which version the virtual all profile has been introduced.

@jan-cerny
Copy link
Collaborator

So according to https://github.com/OpenSCAP/openscap/blob/main/NEWS the virtual profiles have been introduced in 1.3.0. I don't know if Ubuntu/Debians have backported it to older version but it doesn't seem so.

@dodys
Copy link
Contributor

dodys commented Jul 30, 2024

So according to https://github.com/OpenSCAP/openscap/blob/main/NEWS the virtual profiles have been introduced in 1.3.0. I don't know if Ubuntu/Debians have backported it to older version but it doesn't seem so.

would it be possible to just define a profile, instead of running with virtual profiles?

@alanmcanonical alanmcanonical force-pushed the fix_automatus_podman branch 4 times, most recently from 65b2e2e to bc86184 Compare July 30, 2024 11:51
@dodys
Copy link
Contributor

dodys commented Jul 31, 2024

/packit build

@jan-cerny
Copy link
Collaborator

We want to test the rule separately, outside of the profile context, as the rules are in general shared among multiple profiles.

@dodys dodys added this to the 0.1.75 milestone Aug 7, 2024
@dodys
Copy link
Contributor

dodys commented Aug 7, 2024

@jan-cerny @Mab879 so we went with the easy path of in the container manually building and installing openscap. Let me know your thoughts.

@dodys dodys requested review from Mab879 and jan-cerny August 8, 2024 09:33
@Mab879 Mab879 self-assigned this Aug 8, 2024
@Mab879
Copy link
Member

Mab879 commented Aug 8, 2024

@jan-cerny @Mab879 so we went with the easy path of in the container manually building and installing openscap. Let me know your thoughts.

I'm okay that. It doesn't seem to take too long, just about minute or two.

@dodys
Copy link
Contributor

dodys commented Aug 12, 2024

@Mab879 or @jan-cerny if we could merge this one today, it would be nice to use to test some PRs that arrived recently

@Mab879
Copy link
Member

Mab879 commented Aug 12, 2024

@Mab879 or @jan-cerny if we could merge this one today, it would be nice to use to test some PRs that arrived recently

Everything is looks good. The example commit triggering the CI needs to removed then we can merge.

Copy link

codeclimate bot commented Aug 12, 2024

Code Climate has analyzed commit a698789 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 merged commit aea12cf into ComplianceAsCode:master Aug 12, 2024
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. Test Suite Update in Test Suite. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants