Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slmicro5 stig add accounts and amount rules support #12353

Conversation

svet-se
Copy link
Contributor

@svet-se svet-se commented Aug 30, 2024

Description:

  • Add accounts and mount rules to SLE Micro 5 STIG profile

Rationale:

  • According to DISA SLE Micro 5 STIG Version 1, Release: 1 Benchmark Date: 13 Jun 2024

@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label Aug 30, 2024
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Aug 30, 2024
Copy link

openshift-ci bot commented Aug 30, 2024

Hi @svet-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@teacup-on-rockingchair teacup-on-rockingchair force-pushed the slmicro5-stig-add-accounts-and-amount-rules-support branch from 401e27e to e8b4fb9 Compare September 2, 2024 14:26
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label Sep 2, 2024
Copy link

github-actions bot commented Sep 2, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12353
This image was built from commit: 4ef16de

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12353

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12353 make deploy-local

@teacup-on-rockingchair teacup-on-rockingchair self-assigned this Sep 2, 2024
@teacup-on-rockingchair teacup-on-rockingchair added SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates. labels Sep 2, 2024
@teacup-on-rockingchair teacup-on-rockingchair added this to the 0.1.75 milestone Sep 2, 2024
Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teacup-on-rockingchair teacup-on-rockingchair force-pushed the slmicro5-stig-add-accounts-and-amount-rules-support branch from e8b4fb9 to 4ef16de Compare September 4, 2024 12:58
Copy link

codeclimate bot commented Sep 4, 2024

Code Climate has analyzed commit 4ef16de and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

@teacup-on-rockingchair teacup-on-rockingchair merged commit bd48adc into ComplianceAsCode:master Sep 5, 2024
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants