Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Checking missing references has been implemented as
/static-checks/rule-identifiers
Contest test and is part of/static-checks
CI check.Rationale:
missing-references
ctest was unnecessary complicated as it was Bash script callingbuild-scripts/profile_tool.py stats
which is not intended as test but as a tool for obtaining various profile statistics.Newly introduced test in Contest RHSecurityCompliance/contest#265 is easily extensible for new references, waive-able (via Contest waivers), and simpler.
Review Hints:
See CI checks that
missing-references
is not part of ctests and that/static-checks/rule-identifiers
does what's expected (see link above and run in Testing Farm CentOS static-checks).