Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ypbind rules from RHEL10 #12450

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Remove ypbind rules from RHEL10 #12450

merged 1 commit into from
Oct 8, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Oct 1, 2024

Description:

Remove ypbind rules from RHEL10

Rationale:

No longer in RHEL 10.

@Mab879 Mab879 added Update Profile Issues or pull requests related to Profiles updates. RHEL10 Red Hat Enterprise Linux 10 product related. labels Oct 1, 2024
@Mab879 Mab879 added this to the 0.1.75 milestone Oct 1, 2024
@Mab879 Mab879 requested a review from a team as a code owner October 1, 2024 21:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024 •
edited
Loading

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12450
This image was built from commit: c516a1a

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12450

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12450 make deploy-local

@jan-cerny jan-cerny assigned jan-cerny and unassigned jan-cerny Oct 2, 2024
@Mab879 Mab879 force-pushed the remove_ypbind_rhel10 branch from 92315d2 to c516a1a Compare October 2, 2024 15:32
@codeclimate CodeClimate
Copy link

codeclimate bot commented Oct 2, 2024

Code Climate has analyzed commit c516a1a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

@vojtapolasek vojtapolasek self-assigned this Oct 3, 2024
@vojtapolasek
Copy link
Collaborator

/packit retest-failed

1 similar comment
@vojtapolasek
Copy link
Collaborator

/packit retest-failed

vojtapolasek
vojtapolasek approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@vojtapolasek vojtapolasek merged commit 35e9675 into ComplianceAsCode:master Oct 8, 2024
100 checks passed
@Mab879 Mab879 deleted the remove_ypbind_rhel10 branch October 8, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusburghardt marcusburghardt marcusburghardt left review comments

@vojtapolasek vojtapolasek vojtapolasek approved these changes

Assignees

@vojtapolasek vojtapolasek

Labels
RHEL10 Red Hat Enterprise Linux 10 product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.75
Development

Successfully merging this pull request may close these issues.
4 participants
@Mab879 @vojtapolasek @marcusburghardt @jan-cerny