Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Rule] Package kea removed #12464

Merged

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Oct 3, 2024

Description:

  • New Rule Package kea removed
  • Add package_kea_removed to RHEL 10 profiles
    • Exclusion in other profiles.

Rationale:

Kea is the DHCP server in RHEL 10 as the ISC DHCP server is no longer supported.

@Mab879 Mab879 added New Rule Issues or pull requests related to new Rules. RHEL10 Red Hat Enterprise Linux 10 product related. labels Oct 3, 2024
@Mab879 Mab879 added this to the 0.1.75 milestone Oct 3, 2024
@Mab879 Mab879 requested review from a team as code owners October 3, 2024 16:57
Copy link

github-actions bot commented Oct 3, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Oct 3, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12464
This image was built from commit: ac1b53e

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12464

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12464 make deploy-local

@jan-cerny jan-cerny self-assigned this Oct 4, 2024
Copy link

codeclimate bot commented Oct 4, 2024

Code Climate has analyzed commit ac1b53e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@Xeicker Xeicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM

Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified that the rule package_kea_removed is present in the built RHEL 10 DS and that the rule package_dhcp_removed isn't present there.

@jan-cerny
Copy link
Collaborator

@teacup-on-rockingchair please, take a look

@jan-cerny
Copy link
Collaborator

@teacup-on-rockingchair please check it, it's easy, the SUSE profiles are only changed so that the new rule doesn't get there

Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teacup-on-rockingchair teacup-on-rockingchair merged commit 58a8441 into ComplianceAsCode:master Oct 28, 2024
95 of 100 checks passed
@Mab879 Mab879 deleted the package_kea_removed branch October 28, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Rule Issues or pull requests related to new Rules. RHEL10 Red Hat Enterprise Linux 10 product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants