Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enable_dracut_fips_module from RHEL 10 profiles #12467

Merged

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Oct 3, 2024

Description:

Remove enable_dracut_fips_module from RHEL 10 profiles

Rationale:

Due to changes being in FIPS mode in RHEL 10 is rule is being removed for now.

Review Hints:

  1. $ ./build_product rhel10
  2. grep 'enable_dracut_fips_module' build/ssg-rhel10-ds.xml
  3. Observe the rule is no longer in the data stream.

Due to changes being in FIPS mode in RHEL 10 is rule is being removed for
now.
@Mab879 Mab879 added the bugfix Fixes to reported bugs. label Oct 3, 2024
@Mab879 Mab879 added this to the 0.1.75 milestone Oct 3, 2024
@Mab879 Mab879 requested a review from a team as a code owner October 3, 2024 20:48
Copy link

github-actions bot commented Oct 3, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Oct 3, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12467
This image was built from commit: 60ca958

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12467

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12467 make deploy-local

Copy link

codeclimate bot commented Oct 3, 2024

Code Climate has analyzed commit 60ca958 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@mildas mildas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mildas mildas self-assigned this Oct 4, 2024
@mildas mildas merged commit 94f1ca5 into ComplianceAsCode:master Oct 4, 2024
99 of 100 checks passed
@Mab879 Mab879 deleted the remove_enable_dracut_fips_rhel10 branch October 4, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants