Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alma9 more changes (mk2) #12905

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sej7278
Copy link
Contributor

@sej7278 sej7278 commented Jan 27, 2025

Replaces #12883 which got closed accidentally.

Rebased against master (resolved 2 conflicts).

@sej7278 sej7278 requested review from a team as code owners January 27, 2025 13:52
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 27, 2025
Copy link

openshift-ci bot commented Jan 27, 2025

Hi @sej7278. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Mab879 Mab879 added this to the 0.1.76 milestone Jan 27, 2025
Copy link

codeclimate bot commented Jan 27, 2025

Code Climate has analyzed commit 5849e08 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Jan 27, 2025
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Jan 27, 2025
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is merge conflict now. Hopefully we can get the approvals soon.

cc for review
@ComplianceAsCode/suse-maintainers
@ComplianceAsCode/oracle-maintainers

@sej7278
Copy link
Contributor Author

sej7278 commented Jan 29, 2025

Lol, I'll rebase in the morning, problem is other stuff is getting merged quicker than this 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants