Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nonessential services rule #9912

Merged
merged 4 commits into from
Dec 6, 2022
Merged

Add nonessential services rule #9912

merged 4 commits into from
Dec 6, 2022

Conversation

anivan-suse
Copy link
Contributor

Description:

Add to PCI-DSS-V4

  • mask_nonessential_services

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

sle12 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@marcusburghardt
Copy link
Member

There is a conflict with CCEs and I believe most of the SUSE related open PRs are conflicting for the same reason. Could you take a look, please?

@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label Nov 30, 2022
@marcusburghardt marcusburghardt added the SLES SUSE Linux Enterprise Server product related. label Nov 30, 2022
@marcusburghardt marcusburghardt added this to the 0.1.66 milestone Nov 30, 2022
@anivan-suse anivan-suse force-pushed the pci-dss-essential-services branch from fbcf6d8 to 03d2f29 Compare November 30, 2022 16:41
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label Nov 30, 2022
@anivan-suse anivan-suse added the New Rule Issues or pull requests related to new Rules. label Nov 30, 2022
@anivan-suse
Copy link
Contributor Author

There is a conflict with CCEs and I believe most of the SUSE related open PRs are conflicting for the same reason. Could you take a look, please?

Huh, intersting I will find out how this happened. :) Thanks!

@jan-cerny jan-cerny self-assigned this Dec 5, 2022
@codeclimate
Copy link

codeclimate bot commented Dec 5, 2022

Code Climate has analyzed commit 37a8370 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 48.8% (0.1% change).

View more on Code Climate.

@anivan-suse anivan-suse requested a review from jan-cerny December 5, 2022 15:16
@jan-cerny
Copy link
Collaborator

The test fail that the rule isn't present in RHEL 8 is fine because the rule is only for SLES.

@jan-cerny jan-cerny merged commit 5a22e9b into ComplianceAsCode:master Dec 6, 2022
@anivan-suse anivan-suse mentioned this pull request Dec 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

Assignees

@jan-cerny jan-cerny

Labels
New Rule Issues or pull requests related to new Rules. SLES SUSE Linux Enterprise Server product related.
Projects
None yet
Milestone
0.1.66
Development

Successfully merging this pull request may close these issues.
4 participants
@anivan-suse @marcusburghardt @jan-cerny @openshift-merge-robot