Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packit COPR build on EPEL7 and TF testing on CentOS 7 #9942

Merged
merged 6 commits into from
Jan 12, 2023

Conversation

mildas
Copy link
Contributor

@mildas mildas commented Dec 7, 2022

Description:

Extend existing CI with building and testing on CentOS 7.

According to copr-cli, CentOS7 is not available, but EPEL7 is there and it can be used for building:

epel-7-x86_64
Builds are done against CentOS 7 + EPEL 7.

On Testing Farm, CentOS 7 image is available for testing.

Spec file had to be extended with CentOS 7 specific conditions.
ANSSI test is disable on CentOS 7 for now, because RHEL7 doesn't have ANSSI BP-028 profile. The test will need to be extended to ANSSI NT-028 for this case.

Rationale:

Adds build on EPEL 7, where python2 is used.
Adds test coverage for CentOS 7 where profiles are noticeably different than on COS8/COS9.

Review Hints:

See Github Actions in this PR.

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@mildas mildas marked this pull request as draft December 7, 2022 15:12
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Dec 7, 2022
@TomasTomecek
Copy link

Looks like it has worked \o/

testing-farm:centos-7-x86_64 In progress — Tests are running ...

@mildas mildas force-pushed the test_epel7_copr branch 2 times, most recently from b5222a1 to 66c61a5 Compare December 12, 2022 10:55
@mildas mildas force-pushed the test_epel7_copr branch 3 times, most recently from 23420d3 to 2bd2aca Compare January 3, 2023 15:15
@mildas
Copy link
Contributor Author

mildas commented Jan 12, 2023

PR is ready for review 🔥

@codeclimate
Copy link

codeclimate bot commented Jan 12, 2023

Code Climate has analyzed commit 85e864a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.7% (0.0% change).

View more on Code Climate.

@mildas mildas marked this pull request as ready for review January 12, 2023 11:08
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jan 12, 2023
@matusmarhefka matusmarhefka merged commit 22eb7d0 into ComplianceAsCode:master Jan 12, 2023
@matusmarhefka matusmarhefka self-assigned this Jan 12, 2023
@matusmarhefka matusmarhefka added this to the 0.1.66 milestone Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants