Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OL7 stig v2r9 update #9976

Merged
merged 2 commits into from
Jan 4, 2023
Merged

OL7 stig v2r9 update #9976

merged 2 commits into from
Jan 4, 2023

Conversation

freddieRv
Copy link
Contributor

Description:

  • Bump OL7 stig profile version to v2r9
  • Update the XCCDF manual reference
  • Add missing audit rules to the OL7 stig profile
  • Add OL7 to the platform list on the audispd_remote_daemon rules

Rationale:

  • OL7 STIG efforts

@freddieRv freddieRv requested a review from a team as a code owner December 15, 2022 19:25
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@ggbecker ggbecker self-assigned this Jan 3, 2023
ggbecker
ggbecker approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@ggbecker ggbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggbecker
Copy link
Member

ggbecker commented Jan 3, 2023

@freddieRv I believe you have to approve the PR as well in order to merge it :P

@freddieRv
Bump OL7 stig profile version to v2r9
532f1d5 
Signed-off-by: Federico Ramirez <[email protected]>
@freddieRv
Add missing rules to OL7 stig
96a0ee2 
Add missing audit rules to the OL7 stig profile.

Add OL7 to the platform list on the
audispd_remote_daemon rules.

Signed-off-by: Federico Ramirez <[email protected]>
@freddieRv freddieRv force-pushed the ol7-stig-v2r9-update branch from 020e8c2 to 96a0ee2 Compare January 3, 2023 15:38
@freddieRv
Copy link
Contributor Author

@ggbecker GitHub won't let me approve my own PRs 🤔

@ggbecker
Copy link
Member

ggbecker commented Jan 3, 2023

I suspected something like that... we will figure it out how to make it work... probably by removing the need for the group to approve.

@codeclimate
Copy link

codeclimate bot commented Jan 3, 2023

Code Climate has analyzed commit 96a0ee2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.8% (0.0% change).

View more on Code Climate.

@openshift-ci
Copy link

openshift-ci bot commented Jan 3, 2023

@freddieRv: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-rhcos4-moderate 96a0ee2 link true /test e2e-aws-rhcos4-moderate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Mab879 Mab879 added this to the 0.1.66 milestone Jan 4, 2023
@Mab879 Mab879 added Oracle Linux Oracle Linux product related. Update Profile Issues or pull requests related to Profiles updates. STIG STIG Benchmark related. labels Jan 4, 2023
Mab879
Mab879 approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Using project admin to merge without CODEOWNERS.

@Mab879 Mab879 merged commit ff2bbd2 into ComplianceAsCode:master Jan 4, 2023
@vojtapolasek vojtapolasek added the Highlight This PR/Issue should make it to the featured changelog. label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggbecker ggbecker ggbecker approved these changes

@Mab879 Mab879 Mab879 approved these changes

Assignees

@ggbecker ggbecker

Labels
Highlight This PR/Issue should make it to the featured changelog. Oracle Linux Oracle Linux product related. STIG STIG Benchmark related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.66
Development

Successfully merging this pull request may close these issues.
4 participants
@freddieRv @ggbecker @Mab879 @vojtapolasek