Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from window.crypto.randomUUID to uuid package #29

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Conversation

sdemjanenko
Copy link
Contributor

The randomUUID method is only callable from secure contexts (HTTPS): https://developer.mozilla.org/en-US/docs/Web/API/Crypto/randomUUID. This prevents developers from testing recording on the localhost dev endpoints.

We want to provide a good developer experience and as such, we are switching to the uuid package which does not have this issue.

The `randomUUID` method is only callable from secure contexts (HTTPS):
https://developer.mozilla.org/en-US/docs/Web/API/Crypto/randomUUID. This
prevents developers from testing recording on the localhost dev
endpoints.

We want to provide a good developer experience and as such, we are
switching to the uuid package which does not have this issue.
@sdemjanenko sdemjanenko requested a review from a team as a code owner December 13, 2024 22:59
Copy link
Contributor

@cindidong1 cindidong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sdemjanenko sdemjanenko merged commit f8678ae into main Dec 15, 2024
1 check passed
@sdemjanenko sdemjanenko deleted the uuid_fix branch December 15, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants