Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pallet ibc dependencies build errors. #1158

Merged
merged 5 commits into from
Jun 17, 2022
Merged

Fix pallet ibc dependencies build errors. #1158

merged 5 commits into from
Jun 17, 2022

Conversation

Wizdave97
Copy link
Contributor

Issue

Please replace this line with either a link to the ClickUp issue, or a reference to the GitHub issue.

Description

Please replace this line with info that is not in the ClickUp ticket, eg: "also bumps dependency foo version"

Checklist

  • I have updated the cargo docs to reflect changes made by this PR (if applicable)
  • I have updated the book/ to reflect changes made by this PR (if applicable)

@Wizdave97 Wizdave97 requested a review from a team June 16, 2022 11:44
@vercel
Copy link

vercel bot commented Jun 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Updated
pablo-staging ⬜️ Ignored (Inspect) Jun 17, 2022 at 11:07AM (UTC)
pablo-storybook ⬜️ Ignored (Inspect) Jun 17, 2022 at 11:07AM (UTC)
picasso-staging ⬜️ Ignored (Inspect) Jun 17, 2022 at 11:07AM (UTC)
picasso-storybook ⬜️ Ignored (Inspect) Jun 17, 2022 at 11:07AM (UTC)

frame/ibc/Cargo.toml Outdated Show resolved Hide resolved
frame/ibc/src/impls.rs Outdated Show resolved Hide resolved
frame/ibc/src/lib.rs Outdated Show resolved Hide resolved
KaiserKarel
KaiserKarel previously approved these changes Jun 17, 2022
@Wizdave97 Wizdave97 dismissed stale reviews from KaiserKarel and hussein-aitlahcen via 58b3364 June 17, 2022 10:32
@Wizdave97 Wizdave97 requested a review from a team as a code owner June 17, 2022 10:32
@codecov-commenter
Copy link

Codecov Report

Merging #1158 (9f36f59) into main (b5cc1ac) will decrease coverage by 1.03%.
The diff coverage is 32.75%.

@@            Coverage Diff             @@
##             main    #1158      +/-   ##
==========================================
- Coverage   58.99%   57.96%   -1.04%     
==========================================
  Files         316      317       +1     
  Lines       40829    39850     -979     
==========================================
- Hits        24087    23098     -989     
- Misses      16742    16752      +10     
Impacted Files Coverage Δ
...e/ibc/src/benchmarks/tendermint_benchmark_utils.rs 0.00% <0.00%> (ø)
frame/ibc/src/host_functions.rs 0.00% <0.00%> (ø)
frame/ibc/src/port.rs 83.33% <ø> (+44.87%) ⬆️
frame/ibc/src/routing.rs 85.18% <ø> (ø)
frame/ibc-ping/src/lib.rs 31.36% <18.18%> (-0.15%) ⬇️
frame/ibc/src/events.rs 17.76% <20.00%> (-0.12%) ⬇️
frame/ibc/src/lib.rs 12.78% <33.33%> (-0.09%) ⬇️
frame/ibc/src/channel.rs 37.59% <100.00%> (+3.18%) ⬆️
frame/ibc/src/impls.rs 21.29% <100.00%> (-0.73%) ⬇️
frame/ibc/src/tests.rs 100.00% <100.00%> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5cc1ac...9f36f59. Read the comment docs.

@KaiserKarel
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 17, 2022

@bors bors bot merged commit 3259e2c into main Jun 17, 2022
@bors bors bot deleted the david/ibc-rs-fix branch June 17, 2022 13:23
@Wizdave97 Wizdave97 self-assigned this Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

5 participants