PICA-136: upgrade to v0.9.33

[hussein-aitlahcen]

Intro

Upgrade from v0.9.30 to v0.9.33

Migrations

• v0.9.31
  • Properly migrate weights to v2 paritytech/polkadot#6091
  • Companion for #11649: Bound uses of Call paritytech/polkadot#5729
    • Preimage v1
    • Scheduler v4
    • Democracy v1
    • Multisig v1
• v0.9.32
• v0.9.33

Notes

Are we forced to have the old migrations listed? Parity removed the v2 to v3 migration for the Scheduler, I changed it to a combination of v1 to v4 and v3 to v4 as they are idempotent.

I removed price-feed and associated packages as they are outdated and not particularly useful.

The local-integration-tests package must be updated.

[vimukthi-git]

LGTM, I will check a local upgrade on a fork for this.

[vimukthi-git]

Are we forced to have the old migrations listed?

Unfortunately for Pablo we need them to be executed to have the pools in the runtime when testing for now. We will change that in the release 4 after removing the assets hard coding.

[vimukthi-git]

Upgrade on a fork of Picasso works fine. Did not check XCM though. We can check it after making a RC.

[KaiserKarel]

Task linked: PICA-136 Update main code base

[github-actions]

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/af64e2302a466d54ce942e110429af5b511c855e --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/af64e2302a466d54ce942e110429af5b511c855e#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/af64e2302a466d54ce942e110429af5b511c855e#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/af64e2302a466d54ce942e110429af5b511c855e#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/af64e2302a466d54ce942e110429af5b511c855e#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package
For more info on how to use Nix, check out our Nix docs
Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

[github-actions]

Pablo Preview URL

https://pablo-production-jjjc6fhln-composable-finance.vercel.app

[github-actions]

Picasso Preview URL

https://picasso-production-qvpgpuil4-composable-finance.vercel.app

[dzmitry-lahoda]

The local-integration-tests package must be updated.

#3015

[vivekvpandya]

  3     impl<T: Config<Hash = PreimageHash>> OnRuntimeUpgrade for MigrateToV4<T> {                                                         
  2         #[cfg(feature = "try-runtime")]                                                                                                
  1         fn pre_upgrade() -> Result<Vec<u8>, &'static str> {                                                                            
101             assert_eq!(StorageVersion::get::<Pallet<T>>(), 3, "Can only upgrade from version 3");

Just curious above will hit assert as migrate_v1_to_v4() sets version to 4, unless executed without assert or may be directly execute migrate_v3_to_v4() instead of v3::MigrateToV4