Merge pull request #4337 from psychocoderHPC/fix-returnLocalAddress

fix precision cast is returning a reference
ComputationalRadiationPhysics · Nov 8, 2022 · 373bc27 · 373bc27
2 parents 6265559 + ce64b60
commit 373bc27
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/include/picongpu/plugins/radiation/amplitude.hpp b/include/picongpu/plugins/radiation/amplitude.hpp
@@ -227,9 +227,9 @@ namespace pmacc
             template<typename CastToType>
             struct TypeCast<CastToType, picongpu::plugins::radiation::Amplitude<CastToType>>
             {
-                using result = const picongpu::plugins::radiation::Amplitude<CastToType>&;
+                using result = const picongpu::plugins::radiation::Amplitude<CastToType>;
 
-                HDINLINE result operator()(result amplitude) const
+                HDINLINE result operator()(result const& amplitude) const
                 {
                     return amplitude;
                 }

diff --git a/include/pmacc/dimensions/DataSpace.tpp b/include/pmacc/dimensions/DataSpace.tpp
@@ -55,7 +55,7 @@ namespace pmacc
             template<unsigned T_Dim>
             struct TypeCast<int, pmacc::DataSpace<T_Dim>>
             {
-                using result = const pmacc::DataSpace<T_Dim>&;
+                using result = const pmacc::DataSpace<T_Dim>;
 
                 HDINLINE result operator()(const pmacc::DataSpace<T_Dim>& vector) const
                 {

diff --git a/include/pmacc/math/complex/Complex.tpp b/include/pmacc/math/complex/Complex.tpp
@@ -101,7 +101,7 @@ namespace pmacc
             template<typename T_CastToType>
             struct TypeCast<T_CastToType, alpaka::Complex<T_CastToType>>
             {
-                using result = const alpaka::Complex<T_CastToType>&;
+                using result = const alpaka::Complex<T_CastToType>;
 
                 HDINLINE result operator()(const alpaka::Complex<T_CastToType>& complexNumber) const
                 {

diff --git a/include/pmacc/math/vector/Vector.tpp b/include/pmacc/math/vector/Vector.tpp
@@ -256,9 +256,10 @@ namespace pmacc
             template<typename CastToType, int dim, typename T_Accessor, typename T_Navigator, typename T_Storage>
             struct TypeCast<CastToType, ::pmacc::math::Vector<CastToType, dim, T_Accessor, T_Navigator, T_Storage>>
             {
-                using result = const ::pmacc::math::Vector<CastToType, dim, T_Accessor, T_Navigator, T_Storage>&;
+                using result = ::pmacc::math::Vector<CastToType, dim>;
+                using ParamType = ::pmacc::math::Vector<CastToType, dim, T_Accessor, T_Navigator, T_Storage>;
 
-                HDINLINE result operator()(result vector) const
+                HDINLINE result operator()(ParamType const& vector) const
                 {
                     return vector;
                 }