-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial test bench front end #55
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
DOBEN
force-pushed
the
53-test-bench-for-wallet-connect
branch
from
May 22, 2023 10:43
5dc522a
to
1fae6e3
Compare
DOBEN
force-pushed
the
53-test-bench-for-wallet-connect
branch
from
May 22, 2023 10:46
1fae6e3
to
c9585d6
Compare
DOBEN
force-pushed
the
53-test-bench-for-wallet-connect
branch
from
May 22, 2023 11:18
bd168b5
to
4a1f07c
Compare
abizjak
reviewed
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good.
I mainly have input on the UI to make it clearer.
abizjak
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
closes #53
This front end does not protect against bad user input and is meant for testing various scenarios that the wallets and front end can interact with. Negative scenarios (e.g. wrong user input or wrong way of calling functions in the wallets) should be tested.
Changes
Initial test bench
I decided to move the "toggle between mainnet/testnet" into ideas for future versions of the front end since I don't think we will test/deploy the smart contract to mainnet for the time being.
TODO:
JsonRPCClient
once this is merged:Deprecate JSON-RPC support and add support for using the gRPC client for Node API v2 concordium-dapp-libraries#36