fix: Unmarshal response #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgaeta
commented
Sep 25, 2024
| @@ -76,7 +76,7 @@ func (c *Client) CreateBearerToken( | |||
| request.SetBasicAuth(username, password) | |||
|
|
|||
| var target TokenResponse | |||
| response, err := c.wrapper.Do(request, uhttp.WithJSONResponse(target)) | |||
| response, err := c.wrapper.Do(request, uhttp.WithJSONResponse(&target)) | |||
There was a problem hiding this comment.
Could this be the problem?
There was a problem hiding this comment.
Could this be the problem?
AFAIK, not the case, target wouldn't be nil when the pointer reference is being asked, so I don't think this would cause a panic.
ggreer
approved these changes
Sep 25, 2024
|
Fix the linter errors and merge away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're getting an error when creating an API token:
Maybe the problem is that
targetisn't a pointer?