Allow the tempdir used for working with c1zs to be configurable. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirwin
commented
Oct 14, 2023
…re that we write partial c1zs back correctly.
jirwin
force-pushed
the
jirwin/better-tmpdir-support
branch
from
ebbf4c8 to
d732859
Compare
pquerna
reviewed
Oct 14, 2023
| } | ||
|
|
||
| // Returns a C1File instance for the given db filepath. | ||
| func NewC1File(ctx context.Context, dbFilePath string) (*C1File, error) { | ||
| func NewC1File(ctx context.Context, dbFilePath string, opts ...C1FOption) (*C1File, error) { |
There was a problem hiding this comment.
style nit: not sure why this can't just be New() instead of NewC1File?
There was a problem hiding this comment.
This package also contains NewC1ZFile(), so I think it was to disambiguate. We could probably move the details of that function into an option for this function. Will consider that in a separate PR since it'd be API breaking.
pquerna
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default OS tempdir might not be in the place that we'd prefer it to be. Instead of asking users to change the default path systemwide, allow users to configure it while using the SDK.
c1z-temp-dircli flag to any SDK connectorsAlso fixes a bug where failed syncs(local, not service mode) were not properly writing c1zs back to the original file. This enables syncs to be resumed properly.