Generate unique positions #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovromazgon
approved these changes
Jul 12, 2022
lovromazgon
reviewed
Jul 12, 2022
go.mod
Outdated
| @@ -4,6 +4,7 @@ go 1.17 | |||
|
|
|||
| require ( | |||
| github.com/conduitio/conduit-connector-sdk v0.2.0 | |||
| github.com/google/uuid v1.1.2 | |||
There was a problem hiding this comment.
We should use the latest version though, v1.3.0
There was a problem hiding this comment.
I didn't check tbh, I thought it would automatically pull the latest version :S
There was a problem hiding this comment.
I think go get fetches the latest version, unless you already have one locally, then it takes that one. You can use go get my-dependency@latest to always fetch the latest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes positions unique. Works around ConduitIO/conduit#517.
The ability to run multiple generators will be useful for the perf. benchmarks.
Quick checks: