Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode key/payload with schema #217

Closed
wants to merge 1 commit into from
Closed

Encode key/payload with schema #217

wants to merge 1 commit into from

Conversation

lyuboxa
Copy link
Contributor

@lyuboxa lyuboxa commented Oct 18, 2024

Description

Fixes ConduitIO/conduit-connector-sdk#197

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso mentioned this pull request Oct 22, 2024
4 tasks
@hariso
Copy link
Contributor

hariso commented Oct 22, 2024

@lyuboxa thanks for this:) This fix will land in the SDK: ConduitIO/conduit-connector-sdk#196.

However, your cleanup of the code looks good to me, so I've extracted it here: #218.

@lyuboxa
Copy link
Contributor Author

lyuboxa commented Oct 22, 2024

close in favour of #218

@lyuboxa lyuboxa closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Key/payload are not encoded in schema when schema is attached
2 participants