specgen: re-enable acceptance tests, fix validation issues, add more tests #212
Conversation
hariso
changed the title
hariso
changed the title
| @@ -309,12 +326,12 @@ func (s *sourceWithSchemaExtraction) extractPayloadSchema(ctx context.Context, r | |||
| } | |||
|
|
|||
| func (s *sourceWithSchemaExtraction) schemaForType(ctx context.Context, data any, subject string) (schema.Schema, error) { | |||
| srd, err := schema.KnownSerdeFactories[s.config.SchemaType].SerdeForType(data) | |||
| srd, err := schema.KnownSerdeFactories[s.config.SchemaType()].SerdeForType(data) | |||
There was a problem hiding this comment.
I think we should check whether s.config.SchemaType() returns a valid known type.
There was a problem hiding this comment.
We rely on that s.config.SchemaType() converts s.config.SchemaTypeStr to a schema.Type, and SchemaTypeStr has already been validated. But I think you have a point, I can add a test or two to make sure s.config.SchemaType() is doing the conversion successfully.
There was a problem hiding this comment.
@hariso Just checking in. You haven't added a test for this, did you? Just in case I'm not seeing it.
There was a problem hiding this comment.
Ah, good catch, I forgot about this comment.:) I'll add a test or two now.
There was a problem hiding this comment.
I've added to another branch, that's specifically for unit tests: 6cf5795.
Description
Closes #210.
This PR:
specgen/specgen/tests/parse_specs/(tests related to parsing the specs)specgen/specgen/tests/write_and_combine/(tests related to combining an existing connector.yaml file and the generated specs)SourceWithSchemaExtraction.Quick checks: