Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine redmegen and specgen into conn-sdk-cli #246

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

lovromazgon
Copy link
Member

@lovromazgon lovromazgon commented Jan 29, 2025

Description

Instead of having two tools, this introduces a single tool called conn-sdk-cli which we can extend in the future with more commands. The functionality of readmegen and specgen stay the same.

This PR builds on #115.

@lovromazgon lovromazgon requested a review from a team as a code owner January 29, 2025 14:10
Copy link
Contributor

@hariso hariso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice change!

conn-sdk-cli/main.go Outdated Show resolved Hide resolved
@lovromazgon lovromazgon merged commit 2000ba5 into lovro/readmegen Jan 29, 2025
3 checks passed
@lovromazgon lovromazgon deleted the lovro/conn-sdk-cli branch January 29, 2025 16:28
lovromazgon added a commit that referenced this pull request Jan 30, 2025
* add utility for generating readme from specifications

* allow readme to define readmegen tags

* restructure main

* take data from connector.yaml

* improve readmegen util.Generate by introducing options pattern

* fix linter errors

* fix tests

* Combine redmegen and specgen into conn-sdk-cli (#246)

* combine redmegen and specgen into conn-sdk-cli

* make tidy-all

* update year in header

* delete obsolete code

* reword comment

* add end-to-end test, add nicer output for zero values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants